Skip to content

[test] Disable tests for newly introduced Range behavior on earlier OSes #35283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2021
Merged

[test] Disable tests for newly introduced Range behavior on earlier OSes #35283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions test/stdlib/RangeTraps.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,23 +116,26 @@ RangeTraps.test("throughNaN")
_ = ...Double.nan
}

RangeTraps.test("UncheckedHalfOpen")
if #available(macOS 9999, iOS 9999, watchOS 9999, tvOS 9999, *) {
// Debug check was introduced in https://github.com/apple/swift/pull/34961
RangeTraps.test("UncheckedHalfOpen")
.xfail(.custom(
{ !_isDebugAssertConfiguration() },
reason: "assertions are disabled in Release and Unchecked mode"))
{ !_isDebugAssertConfiguration() },
reason: "assertions are disabled in Release and Unchecked mode"))
.code {
expectCrashLater()
var range = Range(uncheckedBounds: (lower: 1, upper: 0))
}

RangeTraps.test("UncheckedClosed")
RangeTraps.test("UncheckedClosed")
.xfail(.custom(
{ !_isDebugAssertConfiguration() },
reason: "assertions are disabled in Release and Unchecked mode"))
{ !_isDebugAssertConfiguration() },
reason: "assertions are disabled in Release and Unchecked mode"))
.code {
expectCrashLater()
var range = ClosedRange(uncheckedBounds: (lower: 1, upper: 0))
}
}

runAllTests()

21 changes: 12 additions & 9 deletions validation-test/stdlib/Range.swift.gyb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,20 +344,23 @@ ${TestSuite}.test("init(uncheckedBounds:)")
expectEqual(upperInt, r.upperBound.value)
}

${TestSuite}.test("init(uncheckedBounds:) with invalid values")
if #available(macOS 9999, iOS 9999, watchOS 9999, tvOS 9999, *) {
// Debug check was introduced in https://github.com/apple/swift/pull/34961
${TestSuite}.test("init(uncheckedBounds:) with invalid values")
.xfail(
.custom(
{ _isDebugAssertConfiguration() },
reason: "unchecked initializer still checks its input in Debug mode"))
.code {
let low = 2
let up = 1
// Check that 'init(uncheckedBounds:)' does not perform precondition checks,
// allowing to create ranges that break invariants.
let r = ${Self}(
uncheckedBounds: (lower: ${Bound}(low), upper: ${Bound}(up)))
expectEqual(low, r.lowerBound.value)
expectEqual(up, r.upperBound.value)
let low = 2
let up = 1
// Check that 'init(uncheckedBounds:)' does not perform precondition checks,
// allowing to create ranges that break invariants.
let r = ${Self}(
uncheckedBounds: (lower: ${Bound}(low), upper: ${Bound}(up)))
expectEqual(low, r.lowerBound.value)
expectEqual(up, r.upperBound.value)
}
}

% for (DestinationSelf, _, _, _) in all_range_types:
Expand Down