[OnoneSimplification] Fixed isDestroyed(after:) #70552
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation just checked that a value's only uses besides the begin_borrow were destroys. That's insufficient to say the value is destroyed _after_ the borrow (i.e. that all its destroys are dominated by the borrow). Add the relevant dominance check. It would be better not to commpute the dominance tree here, so that performance issue can be fixed separately. rdar://119873930
|
@swift-ci please test |
atrick
approved these changes
Dec 20, 2023
|
@swift-ci please build toolchain |
eeckstein
requested changes
Dec 20, 2023
There was a problem hiding this comment.
Sorry, we cannot do this.
Simplifications can modify the CFG and therefore the domtree. We have several of them. As simplifications run inside a single pass without analysis invalidation after each simplification, they must not use any analysis. It would lead to really nasty bugs.
|
Here is another PR which fixes the problem: #70559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation just checked that a value's only uses besides the begin_borrow were destroys. That's insufficient to say the value is destroyed after the borrow (i.e. that all its destroys are dominated by the borrow). Add the relevant dominance check.
It would be better not to compute the dominance tree here, but that compile-time issue can be fixed separately.
rdar://119873930