SimplifyBeginBorrow: fix isDestroyed(after:)
#70559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation just checked that a value's only uses besides the begin_borrow were destroys. That's insufficient to say the value is destroyed after the borrow (i.e. that all its destroys are dominated by the borrow). Add the relevant dominance check. Fixes a compiler crash rdar://119873930
|
@swift-ci test |
atrick
approved these changes
Dec 20, 2023
| } | ||
|
|
||
| func replaceAllDestroys(with replacement: Value, _ context: SimplifyContext) { | ||
| uses.filterUsers(ofType: DestroyValueInst.self).replaceAll(with: replacement, context) | ||
| } | ||
| } | ||
|
|
||
| private extension Instruction { | ||
| func dominates(destroysOf value: Value) -> Bool { |
There was a problem hiding this comment.
For the record. Anyone who sees instruction.dominates will assume it is an implementation of general instruction dominance. An extension of a fundamental type should have an implementation that makes sense wherever that type may be used, regardless of whether the extension is private.
|
Merging because we need to unblock the toolchain build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation just checked that a value's only uses besides the begin_borrow were destroys. That's insufficient to say the value is destroyed after the borrow (i.e. that all its destroys are dominated by the borrow). Add the relevant dominance check.
Fixes a compiler crash
rdar://119873930
Thanks @nate-chandler for narrowing down the problem and for the test cases, which I took from #70552