[cxx-interop] Enable reference-counted types on Windows #83802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/frt-windows
branch
from
8e38513 to
ee18bb8
Compare
|
@swift-ci please smoke test |
egorzhdan
requested review from
Xazax-hun,
fahadnayyar,
hnrklssn,
j-hui,
rjmccall,
susmonteiro and
zoecarver
as code owners
|
When is this metadata needed? |
|
@hnrklssn this is only used when compiling for platforms that use COFF, hence the Windows exclusion that this patch removes. swift/lib/Frontend/CompilerInvocation.cpp Lines 3605 to 3607 in 900be48 |
Xazax-hun
approved these changes
Aug 19, 2025
This enables the use of reference-counted foreign reference types on Windows. As it turns out, the assertion that was failing on Windows previously was unnecessary. This also enabled many of the tests on Windows. rdar://154694125 / resolves swiftlang#82643
egorzhdan
force-pushed
the
egorzhdan/frt-windows
branch
from
ee18bb8 to
b440c4f
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the use of reference-counted foreign reference types on Windows. As it turns out, the assertion that was failing on Windows previously was unnecessary. This also enabled many of the tests on Windows.
rdar://154694125 / resolves #82643