Skip to content

[cxx-interop] Enable reference-counted types on Windows #83802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2025
Merged

[cxx-interop] Enable reference-counted types on Windows #83802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/IRGen/GenMeta.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6880,7 +6880,7 @@ namespace {

void emitInitializeMetadata(IRGenFunction &IGF, llvm::Value *metadata,
MetadataDependencyCollector *collector) {
llvm_unreachable("Not implemented for foreign reference types.");
// Foreign reference types do not currently require extra metadata.
}

// Visitor methods.
Expand Down
3 changes: 0 additions & 3 deletions test/Interop/C/struct/foreign-reference.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
//
// REQUIRES: executable_test

// XFAIL: OS=windows-msvc
// FIXME: Runtime support for C++ foreign reference types is missing on Windows (https://github.com/swiftlang/swift/issues/82643)

import StdlibUnittest
import ForeignReference

Expand Down
3 changes: 0 additions & 3 deletions test/Interop/Cxx/foreign-reference/array-of-classes.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
// REQUIRES: executable_test
// UNSUPPORTED: back_deployment_runtime

// Metadata for foreign reference types is not supported on Windows.
// UNSUPPORTED: OS=windows-msvc

//--- Inputs/module.modulemap

module Test {
Expand Down
3 changes: 0 additions & 3 deletions test/Interop/Cxx/foreign-reference/extensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
// RUN: %target-run-simple-swift(-I %S/Inputs/ -Xfrontend -cxx-interoperability-mode=default -Xfrontend -disable-availability-checking -Onone) | %FileCheck %s
// REQUIRES: executable_test

// Metadata for foreign reference types is not supported on Windows.
// UNSUPPORTED: OS=windows-msvc

import ReferenceCounted

protocol MyProto {
Expand Down
3 changes: 0 additions & 3 deletions test/Interop/Cxx/foreign-reference/inheritance.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
// REQUIRES: executable_test
// RUN: %target-run-simple-swift(-cxx-interoperability-mode=default -Xfrontend -disable-availability-checking -I %S/Inputs)

// TODO: Fix this lit test failure on windows rdar://145218056
// XFAIL: OS=windows-msvc

import Inheritance
import StdlibUnittest

Expand Down
2 changes: 0 additions & 2 deletions test/Interop/Cxx/foreign-reference/multiple-protocol-conformances.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// RUN: split-file %s %t
// RUN: %target-build-swift -I %S/Inputs %t/main.swift %t/second.swift -cxx-interoperability-mode=default -Xfrontend -disable-availability-checking

// XFAIL: OS=windows-msvc

//--- main.swift
import ReferenceCounted

Expand Down
3 changes: 0 additions & 3 deletions test/Interop/Cxx/foreign-reference/print-reference.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@

// REQUIRES: executable_test

// Metadata for foreign reference types is not supported on Windows.
// UNSUPPORTED: OS=windows-msvc

// Temporarily disable when running with an older runtime (rdar://153205860)
// UNSUPPORTED: use_os_stdlib
// UNSUPPORTED: back_deployment_runtime
Expand Down
1 change: 0 additions & 1 deletion test/Interop/Cxx/foreign-reference/reference-counted-irgen.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// RUN: %target-swift-emit-irgen %s -I %S/Inputs -cxx-interoperability-mode=default -Xcc -fignore-exceptions -disable-availability-checking | %FileCheck %s
// XFAIL: OS=windows-msvc

import ReferenceCounted

Expand Down
1 change: 0 additions & 1 deletion test/Interop/Cxx/foreign-reference/reference-counted.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// RUN: %target-run-simple-swift(-I %S/Inputs/ -Xfrontend -enable-experimental-cxx-interop -Xfrontend -validate-tbd-against-ir=none -Xfrontend -disable-llvm-verify -Xfrontend -disable-availability-checking -O)
//
// REQUIRES: executable_test
// XFAIL: OS=windows-msvc

// Temporarily disable when running with an older runtime (rdar://128681137)
// UNSUPPORTED: use_os_stdlib
Expand Down
1 change: 0 additions & 1 deletion test/Interop/Cxx/foreign-reference/witness-table.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// RUN: %target-run-simple-swift(-I %S/Inputs/ -Xfrontend -enable-experimental-cxx-interop -Xfrontend -validate-tbd-against-ir=none -Xfrontend -disable-llvm-verify -g)
//
// REQUIRES: executable_test
// XFAIL: OS=windows-msvc

// Temporarily disable when running with an older runtime (rdar://128681577)
// UNSUPPORTED: use_os_stdlib
Expand Down