[NFC][SILOptimizer]: update outdated docs in DefiniteInit & DRY #83866
Conversation
| // removing it. | ||
|
|
||
| // Helper to remove the instruction from our data structures. | ||
| auto eraseUseInst = [&] { |
There was a problem hiding this comment.
i couldn't resist hoisting this since it seemed like it was just copy-pasted over time... out of curiosity, why are the instructions removed from the Use/NonLoadUses structures in these cases?
|
@swift-ci please smoke test |
| // removing it. | ||
|
|
||
| // Helper to remove the instruction from our data structures. | ||
| auto eraseUseInst = [&] { |
|
@swift-ci please smoke test linux platform |
|
@swift-ci please smoke test windows platform |
2 similar comments
|
@swift-ci please smoke test windows platform |
|
@swift-ci please smoke test windows platform |
|
@eeckstein thanks the the review! could you merge this when you have the chance please? also, cc @janbaig – i suspect there may be potential merge conflicts between this and #83886 just FYI depending on which makes it in first |
|
@jamieQ Got it, thanks for the heads up! |
A number of existing comments in the DI pass alluded to box to stack promotion and assign lowering, both of which seem like they are vestiges of a fairly distant past. Update comments where appropriate. Also DRY a utility in a local function.
jamieQ
force-pushed
the
remove-old-di-comments
branch
from
13235d8 to
bc12429
Compare
|
@swift-ci please smoke test |
|
@eeckstein would you merge this if it still seems okay to you please (i made some minor edits to the original comments and resolved a merge conflict) |
A number of existing comments in the DI pass alluded to box to stack promotion and assign lowering, both of which seem like they are vestiges of a fairly distant past. Update comments where appropriate. Also DRY a utility in a local function.