Sema: Diagnose key path setter availability #83931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
force-pushed
the
key-path-availability
branch
from
c8d4c3a to
8d76643
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
Diagnose the availability of the specific accessors that are referenced implicitly via a key path reference. This causes setter availability to be diagnosed when passing a key path to a function that takes a `WritableKeyPath`. Resolves rdar://157232221.
tshortli
force-pushed
the
key-path-availability
branch
from
8d76643 to
2d5824e
Compare
|
The source compatibility failures appear to be due to existing issues. |
|
@swift-ci please smoke test |
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Sep 24, 2025
Fixes a regression from swiftlang#83931. Resolves rdar://160816035.
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Sep 25, 2025
…king. Accessor availability diagnostics for key path expressions were first introduced by swiftlang#83931. Those changes were insufficient because sometimes key path expressions are generated in the AST with more mutability than is needed by the context and so setter availability could be diagnosed inappropriately. Key path expression binding was refined in swiftlang#84491 to make this less likely to occur. However, there are still some circumstances in which a mutable key path is generated in the AST and then immediately coerced into an immutable key path to satisfy the contextual type. This change infers the immutability of these key path expressions by looking through surrounding conversion expressions.
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Sep 25, 2025
…king. Accessor availability diagnostics for key path expressions were first introduced by swiftlang#83931. Those changes were insufficient because sometimes key path expressions are generated in the AST with more mutability than is needed by the context and so setter availability could be diagnosed inappropriately. Key path expression binding was refined in swiftlang#84491 to make this less likely to occur. However, there are still some circumstances in which a mutable key path is generated in the AST and then immediately coerced into an immutable key path to satisfy the contextual type. This change infers the immutability of these key path expressions by looking through surrounding conversion expressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnose the availability of the specific accessors that are referenced implicitly via a key path reference. This causes setter availability to be diagnosed when passing a key path to a function that takes a
WritableKeyPath.Resolves rdar://157232221.
Also resolves #72809.