Sema: Infer key path immutability during availability checking #84479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
tshortli
force-pushed
the
expr-availability-key-path-mutability-in-conversions
branch
from
b8c8786 to
2f924dc
Compare
|
@swift-ci please test |
tshortli
requested review from
hborla,
slavapestov,
bnbarham and
rintaro
as code owners
|
@swift-ci please test |
|
@swift-ci please test macOS |
|
@swift-ci please test Windows |
hamishknight
approved these changes
Sep 25, 2025
…king. Accessor availability diagnostics for key path expressions were first introduced by swiftlang#83931. Those changes were insufficient because sometimes key path expressions are generated in the AST with more mutability than is needed by the context and so setter availability could be diagnosed inappropriately. Key path expression binding was refined in swiftlang#84491 to make this less likely to occur. However, there are still some circumstances in which a mutable key path is generated in the AST and then immediately coerced into an immutable key path to satisfy the contextual type. This change infers the immutability of these key path expressions by looking through surrounding conversion expressions.
tshortli
force-pushed
the
expr-availability-key-path-mutability-in-conversions
branch
from
2f924dc to
ee988c0
Compare
|
@swift-ci please test |
xedin
approved these changes
Sep 25, 2025
tshortli
deleted the
expr-availability-key-path-mutability-in-conversions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessor availability diagnostics for key path expressions were first introduced by #83931. Those changes were insufficient because sometimes key path expressions are generated in the AST with more mutability than is needed by the context and so setter availability could be diagnosed inappropriately. Key path expression binding was refined in #84491 to make this less likely to occur. However, there are still some circumstances in which a mutable key path is generated in the AST and then immediately coerced into an immutable key path to satisfy the contextual type. This change infers the immutability of these key path expressions by looking through surrounding conversion expressions.