[Concurrency] Fix @Sendable closures not inferring `nonisolated(non…
#84117
+20
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sending)` If there are no explicit concurrency attributes, isolated parameters, or captures associated with the closure it should infer `nonisolated(nonsending)` for the parent conversion injected by the solver (this conversion is injected because the solver cannot check captures to elide it). The change pushes `isIsolationInferenceBoundaryClosure` check down with added benefit of getting preconcurrency context from the parent.
|
@swift-ci please test |
jamieQ
reviewed
Sep 5, 2025
| // expected-error @-1 {{actor-isolated var 'number' cannot be passed 'inout' to 'async' function call}} | ||
| // expected-minimal-error @-2 {{global actor 'MyGlobalActor'-isolated var 'number' can not be used 'inout' from a nonisolated context}} | ||
| // expected-complete-error @-3 {{main actor-isolated var 'number' can not be used 'inout' from a nonisolated context}} | ||
| // expected-complete-warning @-3 {{main actor-isolated var 'number' can not be used 'inout' from a nonisolated context}} |
There was a problem hiding this comment.
out of curiosity, why were the adjustments to these existing tests necessary (here & below)?
There was a problem hiding this comment.
I mentioned that in the description:
The change pushes isIsolationInferenceBoundaryClosure check down with added benefit of getting preconcurrency context from the parent.
The check was preventing from preferring "preconcurrency" from parent context.
|
@swift-ci please smoke test macOS platform |
hborla
approved these changes
Sep 10, 2025
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sending)`
If there are no explicit concurrency attributes, isolated parameters, or captures associated with the closure it should infer
nonisolated(nonsending)for the parent conversion injected by the solver (this conversion is injected because the solver cannot check captures to elide it).The change pushes
isIsolationInferenceBoundaryClosurecheck down with added benefit of getting preconcurrency context from the parent.