[6.2][Concurrency] Prevent some extraneous function conversion sendability checking #84495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sending)` If there are no explicit concurrency attributes, isolated parameters, or captures associated with the closure it should infer `nonisolated(nonsending)` for the parent conversion injected by the solver (this conversion is injected because the solver cannot check captures to elide it). The change pushes `isIsolationInferenceBoundaryClosure` check down with added benefit of getting preconcurrency context from the parent. (cherry picked from commit 3ae34e8)
…have been checked Explicit closure expressions gets their isolation inferred during actor isolation checking, if they appear as a sub-expression to a function conversion we need to delay function checking until the closure was processed. It shouldn't matter for other cases. (cherry picked from commit 61fbaa7)
…ndable` from `nonisolated(nonsending)` function type The isolation doesn't change in this cause and making function type non-Sendable means that it woun't be able to leave the current concurrency domain and the compiler won't generate a thunk. (cherry picked from commit 40c9674)
…nonisolated(nonsending)` `nonisolated(nonsending)` is not presented in interface types which means that references to declarations that have this attribute require a function conversion to apply it. Function conversion checking should detect that and avoid sendability checking for situations like that but there is really no conversion there. (cherry picked from commit ce33100)
xedin
force-pushed
the
dar-157663660-6.2
branch
from
9af27e4 to
a886c5f
Compare
|
@swift-ci please test |
bnbarham
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
Fixes a few situations where Sendable checking was performed on conversions that don't require it.
Fixes
@Sendableclosures not inferringnonisolated(nonsending)If there are no explicit concurrency attributes, isolated parameters, or captures associated with the closure it should infer
nonisolated(nonsending)for the parent conversion injected by the solver (this conversion is injected because the solver cannot check captures to elide it).Moves function conversion check from pre-walk to post-walk. This makes sure that sub-expressions have their isolation computed (especially imported for closures) before checking is performed. The checking itself is idempotent.
Skips checking when function conversion is used to erase
@Sendablefromnonisolated(nonsending)function type, this doesn't require a thunk and so there is no possibility of isolation boundary crossing.Detects situations when function conversion is used to apply
nonisolated(nonsending)attribute to interface type of a declaration.Resolves: rdar://157663660
Main Branch PR: [Concurrency] Fix
@Sendableclosures not inferring `nonisolated(non… #84117, [Concurrency] Prevent some extraneous function conversion sendability checking #84409Risk: Low. This is a narrow fix that prevents some checks from happening and results in more code accepted by the compiler.
Reviewed By: @hborla
Testing: Added new test-cases to the suite.