CMake: make the libswiftCompatibilitySpan symlink relative #84200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we create an absolute one -- this prevents to use the partial toolchain before the installation phase (namely for configurations that run Swift tests on a different device than the builder). Addresses rdar://160277259
|
@swift-ci please test |
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Sep 10, 2025
Currently we create an absolute one -- this prevents to use the partial toolchain before the installation phase (namely for configurations that run Swift tests on a different device than the builder). Addresses rdar://159314722 (cherry picked from commit 4c6c354, swiftlang#84200)
edymtt
changed the title
shahmishal
approved these changes
Sep 10, 2025
edymtt
added a commit
that referenced
this pull request
Sep 11, 2025
…ink (#84201) - **Explanation**: create the symlink from libswiftCompatibilitySpan.dylib to libswiftCore.dylib in the Swift build folder as a relative one instead of an absolute one, to support device testing. - **Scope**: CMake code that creates the symlink for libswiftCompatibilitySpan.dylib during builds - **Issues**: rdar://159314722 - **Original PRs**: #84200 - **Risk**: Low, scope is limited to configurations that run tests on a machine different form the builder, regular CI tests are not affected (since symlinks are valid on the builder itself), and packaging regenerates the symlink with a different mechanism. - **Testing**: ensured at desk that `stdlib/Span` test can run on a different machine (i.e. using `remote-run`) - **Reviewers**: waiting for reviews in the main PR
kathygray-pl
pushed a commit
that referenced
this pull request
Oct 10, 2025
Currently we create an absolute one -- this prevents to use the partial toolchain before the installation phase (namely for configurations that run Swift tests on a different device than the builder). Addresses rdar://160277259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we create an absolute one -- this prevents to use the partial toolchain before the installation phase (namely for configurations that run Swift tests on a different device than the builder).
Addresses rdar://160277259