Skip to content

[6.2] CMake: make the libswiftCompatibilitySpan symlink relative symlink #84201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2025
Merged

[6.2] CMake: make the libswiftCompatibilitySpan symlink relative symlink #84201

merged 1 commit into from
Sep 11, 2025

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Sep 10, 2025

  • Explanation: create the symlink from libswiftCompatibilitySpan.dylib to libswiftCore.dylib in the Swift build folder as a relative one instead of an absolute one, to support device testing.
  • Scope: CMake code that creates the symlink for libswiftCompatibilitySpan.dylib during builds
  • Issues: rdar://159314722
  • Original PRs: CMake: make the libswiftCompatibilitySpan symlink relative #84200
  • Risk: Low, scope is limited to configurations that run tests on a machine different form the builder, regular CI tests are not affected (since symlinks are valid on the builder itself), and packaging regenerates the symlink with a different mechanism.
  • Testing: ensured at desk that stdlib/Span test can run on a different machine (i.e. using remote-run)
  • Reviewers: waiting for reviews in the main PR

@edymtt
[6.2] CMake: make the libswiftCompatibilitySpan symlink relative symlink
ace3f77 
Currently we create an absolute one -- this prevents to use the partial
toolchain before the installation phase (namely for configurations that
run Swift tests on a different device than the builder).

Addresses rdar://159314722

(cherry picked from commit 4c6c354,
 swiftlang#84200)
@edymtt edymtt requested a review from shahmishal September 10, 2025 12:07
@edymtt edymtt requested a review from a team as a code owner September 10, 2025 12:07
@edymtt
Copy link
Contributor Author

edymtt commented Sep 10, 2025

@swift-ci please test

@edymtt edymtt merged commit 7aa050d into swiftlang:release/6.2 Sep 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahmishal shahmishal shahmishal approved these changes

Assignees

No one assigned

Labels

swift 6.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edymtt @shahmishal