utils: Support multiple CMake versions in build.ps1 #84306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake 3.30 passes linker flags to the Swift invocation when it is used as the linker driver. However, Swift cannot parse the linker arguments, so they need to be passed with the `-Xlinker` prefix. This cannot be done uncondtionally as the same arguments are also used with the MSVC toolchain. CMake 4.0 introduces the CMP0181 policy, which allows CMake to parse the `LINKER:` syntax on the linker flags passed on the command line, which simplifies handling of flags. Note that building for Android still requires CMake 3.29 for the time being as we pass a linker driver argument to the CMake linker flags to override the linker used.
|
@swift-ci please test windows platform |
compnerd
reviewed
Sep 15, 2025
|
@swift-ci please test windows platform |
compnerd
approved these changes
Sep 16, 2025
|
@swift-ci please test linux platform |
|
@swift-ci please test macos platform |
|
@swift-ci please smoke test linux platform |
|
@swift-ci please smoke test macos platform |
|
@swift-ci please smoke test linux platform |
1 similar comment
|
@swift-ci please smoke test linux platform |
|
@swift-ci please smoke test Linux platform |
1 similar comment
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please test linux platform |
compnerd
approved these changes
Sep 23, 2025
Steelskin
pushed a commit
to Steelskin/swift
that referenced
this pull request
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake 3.30 passes linker flags to the Swift invocation when it is used as the linker driver. However, Swift cannot parse the linker arguments, so they need to be passed with the
-Xlinkerprefix. This cannot be done uncondtionally as the same arguments are also used with the MSVC toolchain.CMake 4.0 introduces the CMP0181 policy, which allows CMake to parse the
LINKER:syntax on the linker flags passed on the command line, which simplifies handling of flags.Note that building for Android still requires CMake 3.29 for the time being as we pass a linker driver argument to the CMake linker flags to override the linker used.