Skip to content

Conversation

justice-adams-apple
Copy link
Contributor

Xails use-std-vector-typechecker.swift

#84597

@@ -1,3 +1,4 @@
// REQUIRES https://github.com/swiftlang/swift/issues/84597
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't lit require a : after REQUIRES?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep 🤦 , will update it quick. good eye !

@justice-adams-apple justice-adams-apple force-pushed the jadams/xfail-test-use-std-vector-typechecker.swift branch from 1ebe463 to 72f00ab Compare September 30, 2025 20:02
@justice-adams-apple
Copy link
Contributor Author

@swift-ci test

@justice-adams-apple justice-adams-apple force-pushed the jadams/xfail-test-use-std-vector-typechecker.swift branch from 72f00ab to 873f70b Compare September 30, 2025 22:54
@justice-adams-apple
Copy link
Contributor Author

@swift-ci test

Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test still gives us valuable signal on macOS, Linux, Windows, etc. We should not blanket-disable it on all platforms. Let's XFAIL it on armv7 Android specifically instead.

@justice-adams-apple
Copy link
Contributor Author

#84608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants