[cxx-interop] Disable failing test on Android #84608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susmonteiro
requested review from
Xazax-hun,
egorzhdan,
j-hui and
zoecarver
as code owners
egorzhdan
reviewed
Oct 1, 2025
| @@ -1,4 +1,5 @@ | |||
| // RUN: not %target-swift-frontend %s -typecheck -I %S/Inputs -cxx-interoperability-mode=default -diagnostic-style llvm 2>&1 | %FileCheck %s | |||
| // XFAIL: OS=linux-android | |||
There was a problem hiding this comment.
Can we XFAIL this more specifically on armv7 Android?
e.g. // XFAIL: OS=linux-android && CPU=armv7
There was a problem hiding this comment.
Best is // XFAIL: OS=linux-androideabi, that will only disable Android armv7. 😸
susmonteiro
force-pushed
the
susmonteiro/disable-test
branch
from
b8a7a34 to
9992b8c
Compare
|
@swift-ci please smoke test |
finagolfin
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #84597
rdar://161675397