Skip to content

[cxx-interop] Do not warn for implicit default constructors #84764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+1 −14
Closed

[cxx-interop] Do not warn for implicit default constructors #84764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions lib/ClangImporter/ImportDecl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2544,15 +2544,6 @@ namespace {
// constructor available in Swift.
ConstructorDecl *defaultCtor =
synthesizer.createDefaultConstructor(result);
if (cxxRecordDecl) {
auto attr = AvailableAttr::createUniversallyDeprecated(
defaultCtor->getASTContext(),
"This zero-initializes the backing memory of the struct, which "
"is unsafe for some C++ structs. Consider adding an explicit "
"default initializer for this C++ struct.",
"");
defaultCtor->getAttrs().add(attr);
}
ctors.push_back(defaultCtor);
}

Expand Down
3 changes: 0 additions & 3 deletions test/Interop/Cxx/class/inheritance/functions-module-interface.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@
// CHECK-NEXT: public func getCopyCounter() -> UnsafeMutablePointer<Int32>
// CHECK-NEXT: public struct CopyTrackedBaseClass {
// CHECK-NEXT: public init(_ x: Int32)
// CHECK-NEXT: @available(*, deprecated, message: "This zero-initializes the backing memory of the struct, which is unsafe for some C++ structs. Consider adding an explicit default initializer for this C++ struct.")
// CHECK-NEXT: @_transparent public init()
// CHECK-NEXT: @discardableResult
// CHECK-NEXT: public func getX() -> Int32
Expand All @@ -147,7 +146,6 @@

// CHECK-NEXT: public struct CopyTrackedDerivedClass {
// CHECK-NEXT: public init(_ x: Int32)
// CHECK-NEXT: @available(*, deprecated, message: "This zero-initializes the backing memory of the struct, which is unsafe for some C++ structs. Consider adding an explicit default initializer for this C++ struct.")
// CHECK-NEXT: @_transparent public init()
// CHECK-NEXT: @discardableResult
// CHECK-NEXT: public func getDerivedX() -> Int32
Expand All @@ -167,7 +165,6 @@

// CHECK-NEXT: public struct CopyTrackedDerivedDerivedClass {
// CHECK-NEXT: public init(_ x: Int32)
// CHECK-NEXT: @available(*, deprecated, message: "This zero-initializes the backing memory of the struct, which is unsafe for some C++ structs. Consider adding an explicit default initializer for this C++ struct.")
// CHECK-NEXT: @_transparent public init()
// CHECK-NEXT: @discardableResult
// CHECK-NEXT: public func getY() -> Int32
Expand Down
2 changes: 1 addition & 1 deletion test/Interop/Cxx/objc-correctness/pthread_mutexattr_t.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@

import Darwin

_ = pthread_mutexattr_t() // expected-warning {{'init()' is deprecated: This zero-initializes the backing memory of the struct}}
_ = pthread_mutexattr_t()
1 change: 0 additions & 1 deletion test/Interop/Cxx/templates/enable-if-module-interface.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// The `init<T>` constructor template is not yet supported in Swift.

// CHECK: struct HasConstructorWithEnableIf {
// CHECK-NEXT: @available(*, deprecated, message: "This zero-initializes the backing memory of the struct, which is unsafe for some C++ structs. Consider adding an explicit default initializer for this C++ struct.")
// CHECK-NEXT: init()
// CHECK-NEXT:}

Expand Down