[cxx-interop] Do not warn for implicit default constructors #84764
+1
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diagnostic that Swift was emitting (`This zero-initializes the backing memory of the struct ...`) was flaky, because it was only emitted when the default constructor of a C++ struct was instantiated by Swift. If it was instantiated by Clang, the diagnostic wasn't emitted. There is not a lot of value in it. Let's make the behavior consistent by removing the diagnostic. rdar://161999293
egorzhdan
requested review from
beccadax,
fahadnayyar,
hnrklssn,
ian-twilightcoder and
susmonteiro
as code owners
|
@swift-ci please test |
Xazax-hun
approved these changes
Oct 8, 2025
Xazax-hun
requested changes
Oct 8, 2025
|
Is it flaky in the sense that the same test run on the same machine is non deterministic, or flaky in the sense that its behavior differs depending on subtle platform differences, eg SDK version? |
|
@Xazax-hun agreed. Closing this in favor of #84806. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diagnostic that Swift was emitting (
This zero-initializes the backing memory of the struct ...) was flaky, because it was only emitted when the default constructor of a C++ struct was instantiated by Swift. If it was instantiated by Clang, the diagnostic wasn't emitted. There is not a lot of value in it. Let's make the behavior consistent by removing the diagnostic.rdar://161999293