[cxx-interop] Adjust the test for default construction of C types #84806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pthread_mutexattr_t` should be getting its implicit default constructor instantiated by Clang. Due to a Clang bug, the constructor was being instantiated, `needsImplicitDefaultConstructor` was being set to `false`, but the constructor wasn't being added to `decl->members()`. This prevented Swift from correctly importing the constructor. This relies on John's change: llvm/llvm-project#161933. rdar://161999293
egorzhdan
requested review from
Xazax-hun,
fahadnayyar,
hnrklssn,
j-hui,
susmonteiro and
zoecarver
as code owners
|
@swift-ci please smoke test |
This was referenced Oct 10, 2025
Xazax-hun
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pthread_mutexattr_tshould be getting its implicit default constructor instantiated by Clang. Due to a Clang bug, the constructor was being instantiated,needsImplicitDefaultConstructorwas being set tofalse, but the constructor wasn't being added todecl->members(). This prevented Swift from correctly importing the constructor.This relies on John's change: llvm/llvm-project#161933.
rdar://161999293