This repository was archived by the owner on Nov 17, 2021. It is now read-only.
Egulias EmailValidator v3 #1334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why can't we allow |
|
@GrahamCampbell because the |
|
Seems better to allow a wider version range, given all the 2.x versions are allowed, also. |
|
@GrahamCampbell I don't see the need for it. |
|
@GrahamCampbell see for more symfony/symfony#39685 |
|
Ah, I see. 3.0.0 is actually broken. In which case, 👍 for this PR, as is. |
|
Thank you @driesvints. |
|
Merged and released, should unblock Laravel. |
|
Thanks a lot @fabpot! |
This was referenced Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements egulias/email-validator v3. After some back an forth in egulias/EmailValidator#282 @egulias was so kind to provide a new EmailValidation that properly handles the test case of SwiftMailer's IdentificationHeader validation.
^3.1is needed to make use of the new email validation. I've added a class check to use the old one when it isn't present for^2.0.After merging and tagging this PR we can add support for EmailValidator v3 in Laravel. Let me know if you need anything else 👍