Remove async connect flag #32

Merged
merged 1 commit into from Jun 14, 2011

Conversation

Projects
None yet
4 participants
@lenar

lenar commented May 10, 2011

The case isn't handled by the rest of the code. If the connect doesn't happen
right away then subsequent (and too quick) fgets() gets FALSE and everything fails.

@lenar

This comment has been minimized.

Show comment
Hide comment
@lenar

lenar May 10, 2011

And why is there non-blocking "support" at all? When one enables non-blocking
those fgets() won't cut it. I would suggest removing the support from code
altogether, currently it just gives false impression on available functionality.

lenar commented May 10, 2011

And why is there non-blocking "support" at all? When one enables non-blocking
those fgets() won't cut it. I would suggest removing the support from code
altogether, currently it just gives false impression on available functionality.

@xdecock

This comment has been minimized.

Show comment
Hide comment
@xdecock

xdecock May 10, 2011

Member

I have started an async branch, just need time to implement it as you need a state tracker :)

Member

xdecock commented May 10, 2011

I have started an async branch, just need time to implement it as you need a state tracker :)

@lenar

This comment has been minimized.

Show comment
Hide comment
@lenar

lenar May 10, 2011

Nevertheless current code is broken, please merge the connect flag removal.

lenar commented May 10, 2011

Nevertheless current code is broken, please merge the connect flag removal.

@schmittjoh

This comment has been minimized.

Show comment
Hide comment
@schmittjoh

schmittjoh Jun 14, 2011

@fabpot, ping

Can this be merged as this currently is broken on Windows 7?

@fabpot, ping

Can this be merged as this currently is broken on Windows 7?

@fabpot fabpot merged commit 172b799 into swiftmailer:4.1 Jun 14, 2011

@ghost ghost referenced this pull request Oct 24, 2011

Closed

Add STARTTLS support #52

makasim pushed a commit to formapro-forks/swiftmailer that referenced this pull request Jul 26, 2017

Merge pull request #32 from stof/default_values
Added missing initialization of the arrays for TestHandler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment