Skip to content
This repository was archived by the owner on Nov 17, 2021. It is now read-only.

Remove async connect flag #32

Merged
merged 1 commit into from
Jun 14, 2011
Merged

Remove async connect flag #32

merged 1 commit into from
Jun 14, 2011

Conversation

lenar
Copy link

@lenar lenar commented May 10, 2011

The case isn't handled by the rest of the code. If the connect doesn't happen
right away then subsequent (and too quick) fgets() gets FALSE and everything fails.

@lenar
Copy link
Author

lenar commented May 10, 2011

And why is there non-blocking "support" at all? When one enables non-blocking
those fgets() won't cut it. I would suggest removing the support from code
altogether, currently it just gives false impression on available functionality.

@xdecock
Copy link
Member

xdecock commented May 10, 2011

I have started an async branch, just need time to implement it as you need a state tracker :)

@lenar
Copy link
Author

lenar commented May 10, 2011

Nevertheless current code is broken, please merge the connect flag removal.

@schmittjoh
Copy link

@fabpot, ping

Can this be merged as this currently is broken on Windows 7?

@fabpot fabpot merged commit 172b799 into swiftmailer:4.1 Jun 14, 2011
@swiftmailer swiftmailer mentioned this pull request Oct 24, 2011
makasim pushed a commit to formapro-forks/swiftmailer that referenced this pull request Jul 26, 2017
Added missing initialization of the arrays for TestHandler
go-redrock-nicolas added a commit to go-redrock-software/swiftmailer that referenced this pull request May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants