Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Remove async connect flag #32
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
lenar
May 10, 2011
And why is there non-blocking "support" at all? When one enables non-blocking
those fgets() won't cut it. I would suggest removing the support from code
altogether, currently it just gives false impression on available functionality.
lenar
commented
May 10, 2011
|
And why is there non-blocking "support" at all? When one enables non-blocking |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
xdecock
May 10, 2011
Member
I have started an async branch, just need time to implement it as you need a state tracker :)
|
I have started an async branch, just need time to implement it as you need a state tracker :) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
lenar
commented
May 10, 2011
|
Nevertheless current code is broken, please merge the connect flag removal. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
schmittjoh
commented
Jun 14, 2011
|
@fabpot, ping Can this be merged as this currently is broken on Windows 7? |
fabpot
merged commit 172b799
into
swiftmailer:4.1
Jun 14, 2011
ghost
referenced this pull request
pushed a commit
to formapro-forks/swiftmailer
that referenced
this pull request
Jul 26, 2017
lenar commentedMay 10, 2011
The case isn't handled by the rest of the code. If the connect doesn't happen
right away then subsequent (and too quick) fgets() gets FALSE and everything fails.