Skip to content

Conversation

alionazherdetska
Copy link
Contributor

📄 Description

This update corrects the behavior of the banner examples in the documentation.

  • The Reset Banner button is now hidden initially.
  • It only becomes visible after the banner has been dismissed via the close button or programmatically

📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • ✔️ New and existing unit tests pass locally with my changes

@alionazherdetska alionazherdetska requested review from a team as code owners August 21, 2025 14:01
@alionazherdetska alionazherdetska linked an issue Aug 21, 2025 that may be closed by this pull request
Copy link

changeset-bot bot commented Aug 21, 2025

🦋 Changeset detected

Latest commit: 219257b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@swisspost/design-system-documentation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alionazherdetska alionazherdetska changed the title 6000 fix banner examples behavior in documentation chore(docs): fix <post-banner> Webcomponent examples behavior in documentation Aug 21, 2025
@alionazherdetska alionazherdetska changed the title chore(docs): fix <post-banner> Webcomponent examples behavior in documentation chore(docs): fix <post-banner> Web Component examples behavior in documentation Aug 21, 2025
@alionazherdetska alionazherdetska marked this pull request as draft August 21, 2025 14:06
@alionazherdetska alionazherdetska marked this pull request as ready for review August 28, 2025 10:05
@myrta2302 myrta2302 requested review from myrta2302 and removed request for alizedebray September 1, 2025 06:54
@swisspost swisspost deleted a comment from swisspost-bot Sep 11, 2025
@swisspost swisspost deleted a comment from swisspost-bot Sep 11, 2025
@alionazherdetska alionazherdetska force-pushed the 6000-fix-banner-examples-behavior-in-documentation branch 2 times, most recently from 355e40a to 6351186 Compare September 11, 2025 14:38
@swisspost swisspost deleted a comment from swisspost-bot Sep 11, 2025
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Sep 11, 2025

Related Previews

@leagrdv leagrdv self-requested a review September 12, 2025 07:27
Copy link
Contributor

@leagrdv leagrdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as intended but I feel like when dismissed, the code preview should still be the banner. Right now, it's the reset button code.

Capture d'écran 2025-09-12 095944

Also, could you update the dismissal behavior on the snapshot as well? When you dismiss a banner, it just disappear but there is no "Reset button" to show it back.

…fix-banner-examples-behavior-in-documentation
@alionazherdetska alionazherdetska force-pushed the 6000-fix-banner-examples-behavior-in-documentation branch 3 times, most recently from 8648daf to 53c37b0 Compare September 12, 2025 10:29
Copy link

Copy link
Contributor

@leagrdv leagrdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more a fix than a chore, so if you could update the PR title before merging to something like fix(docs): <post-banner> web component ex..., that'd be great :)

@alionazherdetska alionazherdetska changed the title chore(docs): fix <post-banner> Web Component examples behavior in documentation fix(docs): fix <post-banner> Web Component examples behavior in documentation Sep 15, 2025
@alionazherdetska alionazherdetska merged commit b703a5f into main Sep 15, 2025
15 checks passed
@alionazherdetska alionazherdetska deleted the 6000-fix-banner-examples-behavior-in-documentation branch September 15, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix banner examples behavior in documentation
4 participants