-
Notifications
You must be signed in to change notification settings - Fork 20
fix(docs): fix <post-banner>
Web Component examples behavior in documentation
#6076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): fix <post-banner>
Web Component examples behavior in documentation
#6076
Conversation
🦋 Changeset detectedLatest commit: 219257b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
<post-banner>
Web Component examples behavior in documentation
packages/documentation/src/stories/components/banner/web-component/post-banner.stories.ts
Outdated
Show resolved
Hide resolved
355e40a
to
6351186
Compare
Related Previews |
…ttps://github.com/swisspost/design-system into 6000-fix-banner-examples-behavior-in-documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as intended but I feel like when dismissed, the code preview should still be the banner. Right now, it's the reset button code.

Also, could you update the dismissal behavior on the snapshot as well? When you dismiss a banner, it just disappear but there is no "Reset button" to show it back.
packages/documentation/src/stories/components/banner/banner.stories.ts
Outdated
Show resolved
Hide resolved
…fix-banner-examples-behavior-in-documentation
8648daf
to
53c37b0
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more a fix than a chore, so if you could update the PR title before merging to something like fix(docs): <post-banner>
web component ex..., that'd be great :)
<post-banner>
Web Component examples behavior in documentation<post-banner>
Web Component examples behavior in documentation
📄 Description
This update corrects the behavior of the banner examples in the documentation.
📝 Checklist