Skip to content

Conversation

@tankorsmash
Copy link
Contributor

@tankorsmash tankorsmash commented Jul 14, 2020

I was trying to use Ctrl-A to highlight the text I was writing in a text_input and this seems to fix it.

I'd bet something similar could be used for alt, shift, and super/windows key but I haven't tested those myself so I didn't want to commit it.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 54.165% when pulling db410e0 on tankorsmash:patch-1 into c84315e on swistakm:master.

@swistakm swistakm merged commit 20b5cb7 into pyimgui:master Jul 17, 2020
@swistakm
Copy link
Member

Hey! Thanks for PR! It had few small issues:

  • didn't capture ctrl release properly
  • import errors
  • didn't fix the functionality on macOS where Command (super) key takes role of Ctrl key in "highlight all" shortcut

I have fixed all of them manually and merged to master.

@swistakm swistakm added the release pending Merged but still needs official release label Jul 17, 2020
@swistakm
Copy link
Member

Will try to release this on PyPI by the end of the week.

@tankorsmash
Copy link
Contributor Author

tankorsmash commented Jul 17, 2020 via email

@swistakm
Copy link
Member

Feature released in 1.2.0

@swistakm swistakm removed the release pending Merged but still needs official release label Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants