enable glumpy interaction #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Great! Thanks! I will draft new release by the end of the week. |
Member
|
Improvement released in 1.2.0 |
Contributor
Author
|
Thanks, that's great! It's working nicely.
…----- Mail original -----
De: "Michał Jaworski" ***@***.***>
À: "swistakm/pyimgui" ***@***.***>
Cc: "Ivo Ihrke" ***@***.***>, "Author" ***@***.***>
Envoyé: Lundi 20 Juillet 2020 20:27:57
Objet: Re: [swistakm/pyimgui] enable glumpy interaction (#157)
Improvement released in 1.2.0
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#157 (comment)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear authors,
this is a very minor modification that enables the use of imgui with the glumpy library
glumpy/glumpy#174
glumpy/glumpy#177
The definition of the projection matrix should be a ctypes or numpy array.
In the current implementation, it leads to an error in baseplatform.py of pyopengl.
The error is documented in pull request 177 above, comment of
dan90210 commented on Jan 8, 2019
The submitted change fixes the problem. For the implementation
I chose ctypes over numpy (as suggested in the thread above)
because it is already used in opengl.py and only requires a very
minor change.
I suppose the problem could also occur in other contexts since it
regards the interaction of pyimgui and pyopengl.
best regards,
Ivo