Skip to content

fix UnicodeDecodeError occurences in input_text_multiline #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swistakm merged 1 commit into from
Nov 25, 2020
Merged

fix UnicodeDecodeError occurences in input_text_multiline #186

swistakm merged 1 commit into from
Nov 25, 2020

Conversation

@TTimo
Copy link
Contributor

@TTimo TTimo commented Nov 19, 2020

When the input_text_multiline buffer cuts in the wrong place, this code was throwing a UnicodeDecodeError exception.

  File "imgui/core.pyx", line 4990, in imgui.core.input_text_multiline
  File "imgui/core.pyx", line 323, in imgui.core._from_bytes
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xde in position 10000: unexpected end of data

@coveralls
Copy link

coveralls commented Nov 19, 2020

Coverage Status

Coverage remained the same at 49.589% when pulling 8106fae on TTimo:input_text_multiline into 4eb8a65 on swistakm:master.

@swistakm
Copy link
Member

swistakm commented Nov 25, 2020

Thanks for contribution!

@swistakm swistakm merged commit d822f9c into pyimgui:master Nov 25, 2020
@swistakm swistakm added the release pending Merged but still needs official release label Nov 25, 2020
@swistakm swistakm removed the release pending Merged but still needs official release label Dec 16, 2020
@swistakm
Copy link
Member

swistakm commented Dec 16, 2020

Released as 1.3.0:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TTimo @coveralls @swistakm