Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTRIBUTE link on homepage broken #8290

Closed
trosel opened this issue Feb 1, 2017 · 4 comments
Closed

CONTRIBUTE link on homepage broken #8290

trosel opened this issue Feb 1, 2017 · 4 comments
Labels
- Bug tracker - Broken URL Documentation ✏ Fixed in develop stale marked as a stale issue/pr (usually by a bot)

Comments

@trosel
Copy link

trosel commented Feb 1, 2017

http://spacemacs.org/doc/CONTRIBUTE.html
@smile13241324
Copy link
Collaborator

Same for http://develop.spacemacs.org/doc/CONTRIBUTE.html

smile13241324 added a commit to smile13241324/spacemacs that referenced this issue Mar 5, 2017
@smile13241324
Fix broken link to CONTRIBUTE.org in documentation to fix syl20bnr#8290
f45d867 
In 2015 a file CONTRIBUTE.org was existing in the /doc folder.
In addition a CONTRIBUTING.md file was existing in the project root folder.
This was merged into a CONTRIBUTING.org file, which is still located in the project root.
However the documentation publishing system was still looking only in the doc folder.
In addition the external documentation is still referring to the old CONTRIBUTE.html which is not longer existing.

I have now included a new function called prior to publishing
which is copying the documents from the projects root into the doc folder.
As a side effect it renames the CONTRIBUTING.org to the old CONTRIBUTE.org
to support the external documentation.
@smile13241324
Copy link
Collaborator

Thanks for reporting, I have added a fix to the publishing mechanism which should solve the issue.

@smile13241324
Copy link
Collaborator

Link to related PR: #8468

This was referenced Apr 13, 2017
Open
Closed
Open
Open
syl20bnr pushed a commit that referenced this issue Apr 18, 2017
@smile13241324 @syl20bnr
Fix broken link to CONTRIBUTE.org in documentation to fix #8290
092f98f 
In 2015 a file CONTRIBUTE.org was existing in the /doc folder.
In addition a CONTRIBUTING.md file was existing in the project root folder.
This was merged into a CONTRIBUTING.org file, which is still located in the project root.
However the documentation publishing system was still looking only in the doc folder.
In addition the external documentation is still referring to the old CONTRIBUTE.html which is not longer existing.

I have now included a new function called prior to publishing
which is copying the documents from the projects root into the doc folder.
As a side effect it renames the CONTRIBUTING.org to the old CONTRIBUTE.org
to support the external documentation.
ksonney pushed a commit to ksonney/spacemacs that referenced this issue Apr 25, 2017
@smile13241324
Fix broken link to CONTRIBUTE.org in documentation to fix syl20bnr#8290
539b4b7 
In 2015 a file CONTRIBUTE.org was existing in the /doc folder.
In addition a CONTRIBUTING.md file was existing in the project root folder.
This was merged into a CONTRIBUTING.org file, which is still located in the project root.
However the documentation publishing system was still looking only in the doc folder.
In addition the external documentation is still referring to the old CONTRIBUTE.html which is not longer existing.

I have now included a new function called prior to publishing
which is copying the documents from the projects root into the doc folder.
As a side effect it renames the CONTRIBUTING.org to the old CONTRIBUTE.org
to support the external documentation.
ksonney pushed a commit to ksonney/spacemacs that referenced this issue Apr 26, 2017
@smile13241324 @ksonney
Fix broken link to CONTRIBUTE.org in documentation to fix syl20bnr#8290
de9a734 
In 2015 a file CONTRIBUTE.org was existing in the /doc folder.
In addition a CONTRIBUTING.md file was existing in the project root folder.
This was merged into a CONTRIBUTING.org file, which is still located in the project root.
However the documentation publishing system was still looking only in the doc folder.
In addition the external documentation is still referring to the old CONTRIBUTE.html which is not longer existing.

I have now included a new function called prior to publishing
which is copying the documents from the projects root into the doc folder.
As a side effect it renames the CONTRIBUTING.org to the old CONTRIBUTE.org
to support the external documentation.
tranchis pushed a commit to tranchis/spacemacs that referenced this issue May 25, 2017
@smile13241324 @tranchis
Fix broken link to CONTRIBUTE.org in documentation to fix syl20bnr#8290
7a3cebb 
In 2015 a file CONTRIBUTE.org was existing in the /doc folder.
In addition a CONTRIBUTING.md file was existing in the project root folder.
This was merged into a CONTRIBUTING.org file, which is still located in the project root.
However the documentation publishing system was still looking only in the doc folder.
In addition the external documentation is still referring to the old CONTRIBUTE.html which is not longer existing.

I have now included a new function called prior to publishing
which is copying the documents from the projects root into the doc folder.
As a side effect it renames the CONTRIBUTING.org to the old CONTRIBUTE.org
to support the external documentation.
CodingSolo pushed a commit to CodingSolo/spacemacs that referenced this issue Oct 29, 2018
@smile13241324
Fix broken link to CONTRIBUTE.org in documentation to fix syl20bnr#8290
60ce254 
In 2015 a file CONTRIBUTE.org was existing in the /doc folder.
In addition a CONTRIBUTING.md file was existing in the project root folder.
This was merged into a CONTRIBUTING.org file, which is still located in the project root.
However the documentation publishing system was still looking only in the doc folder.
In addition the external documentation is still referring to the old CONTRIBUTE.html which is not longer existing.

I have now included a new function called prior to publishing
which is copying the documents from the projects root into the doc folder.
As a side effect it renames the CONTRIBUTING.org to the old CONTRIBUTE.org
to support the external documentation.
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
- Bug tracker - Broken URL Documentation ✏ Fixed in develop stale marked as a stale issue/pr (usually by a bot)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@syl20bnr @trosel @smile13241324