ivy: spacemacs-help: Fix candidate layers with no packages #10000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a layer doesn't have a package, its name was added to the candidate list
as a symbol instead of a string, breaking actions such as
layer-action-open-packages which expect a string.
Spacemacs is great, keep up the good work :)
Edit: Just noticed the pull request number! Do I get eternal glory now? :P
Edit2:
Steps to reproduce:
spacemacs-base
for the distribution andvim
for editing styleSPC f e d
) and replacehelm
layer withivy
ivy-spacemacs-help
withSPC h SPC
and search forvingar no packages
(Or any other layer that doesn't own any packages)M-o p
to open Vinegar'spackages.el
. You will getWrong type argument: stringp, vinegar
.