ivy: spacemacs-help: Fix candidate layers with no packages#10000
Closed
nikital wants to merge 1 commit intosyl20bnr:developfrom
Closed
ivy: spacemacs-help: Fix candidate layers with no packages#10000nikital wants to merge 1 commit intosyl20bnr:developfrom
nikital wants to merge 1 commit intosyl20bnr:developfrom
Conversation
When a layer doesn't have a package, its name was added to the candidate list as a symbol instead of a string, breaking actions such as layer-action-open-packages which expect a string.
e252b64 to
0d69da4
Compare
Contributor
Author
Contributor
|
Not denying that what you did works, but I think it would help if you also provided a way to reproduce this bug in the description, so others can try it out for themselves and give you a 👍. |
Contributor
Author
|
@SDWolf That's a good point, thanks. Updated the pull request with steps to reproduce. |
Owner
|
Good catch, Thank you ! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a layer doesn't have a package, its name was added to the candidate list
as a symbol instead of a string, breaking actions such as
layer-action-open-packages which expect a string.
Spacemacs is great, keep up the good work :)
Edit: Just noticed the pull request number! Do I get eternal glory now? :P
Edit2:
Steps to reproduce:
spacemacs-basefor the distribution andvimfor editing styleSPC f e d) and replacehelmlayer withivyivy-spacemacs-helpwithSPC h SPCand search forvingar no packages(Or any other layer that doesn't own any packages)M-o pto open Vinegar'spackages.el. You will getWrong type argument: stringp, vinegar.