Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The node connected to the wallet is not displayed in the delegation destination when setting the delegation harvest #1106

Closed
dusanjp opened this issue Feb 12, 2021 · 7 comments · Fixed by #1502
Assignees
Labels
P3 Issue Minor defect in aesthetics

Comments

@dusanjp
Copy link

dusanjp commented Feb 12, 2021

in v0.14.0
The node connected to the wallet is not displayed in the delegation destination when setting the delegation harvest

in this case
You can find the desired delegation destination peer node and reconnect to it to find the target delegation destination.

I think it is desirable to be able to display the wallet connection node as the delegation destination without changing the wallet connection node.

@cryptoBeliever cryptoBeliever added the P3 Issue Minor defect in aesthetics label Feb 13, 2021
@cryptoBeliever
Copy link
Contributor

@bassemmagdy I think it's because /node/peers for the current node don't return it. I think it should be improved and we should add the current node if it meets the harvesting nodes list requirements.

@Pow1404 Pow1404 added this to Issue Backlog in Symbol Desktop Wallet Feb 15, 2021
@bassemmagdy bassemmagdy moved this from Issue Backlog to In progress in Symbol Desktop Wallet Feb 21, 2021
@bassemmagdy bassemmagdy self-assigned this Feb 21, 2021
bassemmagdy added a commit to bassemmagdy/symbol-desktop-wallet that referenced this issue Feb 21, 2021
@bassemmagdy bassemmagdy moved this from In progress to Review in progress in Symbol Desktop Wallet Feb 21, 2021
bassemmagdy added a commit that referenced this issue Mar 2, 2021
* fix #1106

* fixes #1162

* fix #1022

* fix #1061

* display full message in invoice fixes #1062

* fixes #560

* update

* fix #1188

* update translation

* update author

* fixes #723
@bassemmagdy bassemmagdy moved this from Review in progress to Ready for testing in Symbol Desktop Wallet Mar 2, 2021
@cryptoBeliever
Copy link
Contributor

Fixed.

@cryptoBeliever cryptoBeliever moved this from Ready for testing to Done in Symbol Desktop Wallet Mar 3, 2021
rg911 added a commit that referenced this issue Mar 11, 2021
* network state reset on logout

* Duplicate notif fix (#1176)

* dup notif fix: 2 listeners(1 network-blocks, 1 for account-txs), closing txs-listener on subs/unsubs

* Removed default transaction fees

* temp hashLockListener added to announceHashAndAggregateBonded

* Fixed lockFund not get notificed issue

* dup notif fix: 2 listeners(1 network-blocks, 1 for account-txs), closing txs-listener on subs/unsubs

* temp hashLockListener added to announceHashAndAggregateBonded

* Fixed lockFund not get notificed issue

* Simply the reset signer

* Updated sdk to alpha version

* Fixed build error

Co-authored-by: Baha <bahadir.yilmaz@nem.software>
Co-authored-by: yilmazbahadir <yilmazbahadir@gmail.com>

* fix bugs (#1179)

* fix bugs

* linting

* update translation

* update translation

* update

* fix #1140

* Fixed hardcode translation (#1177)

* Fixed hardcode translation

* Corrected translation

* Update add account for Ledger profile (#1164)

Not show verification screen when creating profile and add more Ledger account

* hide message encryption on invoice page (#1153)

* moved tx export button to filters bar, added tooltips (#1152)

* Remove 'BOLOS' word on Ledger related messages (#1186)

* improve ja-JP (#1187)

* Top navbar: made icons clickable, added settings label (#1194)

* made icons clickable, added settings label

* fixed lint

* fixed test

* improved transactions table columns widths (#1191)

* Changed dashboard icons (#1192)

* changed dashboard icons

* fixed navigation tabs icons

* Invoice page: improved layout and label (#1195)

* fee selector now has full width when send is hidden

* added icon to QR download button

* moved QR to the bottom, replaced 'Assets' with 'Mosaic', hide hex if mosaic has a name

* fixed lint

* Fixed entitlement playlist issue (#1204)

* transactions table: display amounts of outgoing txs negative (#1193)

* Fixed amount not displaying for main net (#1199)

* Update Ledger creation profile flow (#1196) (#1214)

* #876: Namespaces - metadata editing - strange behaviour fixed (#1213)

* show a loading indication during asynchronous operations (#1207)

* Removing seed account limit (#1206)

* remove seed accounts limitations

* fix unit tests

* Revert "Changed dashboard icons (#1192)" (#1205)

This reverts commit d215d0a.

* fixed profile does not exist error message, changed input background, refactoring (#1201)

* Fix ci build (#1215)

* fix ci build

* update

* improve ja-JP (#1216)

* Minor capitalization problem (#1221)

* Fixed block listener not subscribed bug (#1233)

* settings: fixed account selector dropdown width (#1231)

* Fetch harvesting status periodically  (#1225)

* periodicly poll harvesting status and harvested blocks #1222

* update

* fixed create metadata confirmation layout (#1227)

* Namespaces descending sorting (#1223)

* Fixed descending sorting

* Removed spaces

* Rewrited sortingMethodChooser function

* Tried to remove extra variables

* Fixed syntax

* Create profile deletion button, move logout to top navbar (#1230)

* moved logout button from settings to top navbar

* created delete profile button in settings

* show mainnet not launched yet (#1212)

* fix #1190

* update translation

* Namespace duration fix (#1209)

* fix #1208

* fix namespace duration validation

* Issues fixes (#1189)

* fix #1106

* fixes #1162

* fix #1022

* fix #1061

* display full message in invoice fixes #1062

* fixes #560

* update

* fix #1188

* update translation

* update author

* fixes #723

* Add mosaic supply (#1202)

* add supply mosaic to aggregate fixes #1088 #723

* update

* resolving conflicts

* improve ja-JP (#1237)

* Added icon to switch language (#1240)

* Import QR improvements (#1200)

* hide fee warning if displayOnly is true

* hide QR download button, layout improvements

* Added 'Encrypted message' message and remove extra language icon (#1247)

* #881: Restrictions - presenting multisig restrictions under cosigner (#1244)

* #1029: Message with 1024 characters not possible (#1210)

* increase scrollbar thumb width/height in Chrome and Electron (#1251)

* fix duplicate error notification #1171 (#1254)

* fixing bugs (#1241)

* fix #877

* update

* fix language changing bug on login screen

* fix #1245

* linting

* fix #1246

* linting

* fix import mnemonic bug (#1224)

* fix #1219

* update

* hide hint on login when a profile doesn't have one (#1239)

* hide password hint on login screen if profile doesn't have one fixes #1238

* linting

* Added support for opt in accounts curve (#1252)

* Added support for opt in accounts curve

* Linting fixes

* Fixed UI and unable to transfer with opt in account bug

* Resolved #1253

* Fixed unit tests

Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>
Co-authored-by: Steven Liu <xian.f.liu@gmail.com>

* Fixed translations (#1198)

* fixed translations

* back up -> backup, updated Chinese translation

* Moved opt-in accounts logic from .env file to json (#1265)

Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>

* fixed wrong mosaic/amount/direction shown when editing aggregate tx (#1263)

* several modal dialog layout fixes (#1262)

* fixed edit metadata mosaic, fixed label (#1258)

* improve ja (#1256)

* replaced refresh button (#1259)

* fix #784 (#1211)

* account selection: show balance zero instead of N/A (#1226)

* login: validate password on submit (#1218)

* reset account selection when starting import (#1260)

* Updated publisher for windows to NGL

* Offline transactions feature (#1248)

* Raw skeleton

* Offline working with QR no UI

* UI improved

* Improved mock models

* Import signed QR

* Cosign with UI

* Last UI tweaks

* Fixed mainnet support

* linting fixes

* Merging error fix

* Removed ssh dependency and changed for https

* Solved signer not changing and minimal UI

* Mainnet profile first and added address to account signer field

* Added listeners to broadcast results

* Updated symbol-qr-library to alpha release and small ui fix

Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>

* Fixed balance showing problem in import

* restored previous change

* Fixed balance display for opt in account

* Check if currentProfile is initialized before initializing accounts (#1267)

Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>

* Re subscribe ws (#1266)

* re-subscriber if listener is closed

* retry reconnecting ws

* update sdk

* update

* linting

* update

* Fix Import mnemonic bad accounts (#1269)

* Profile is now created when finalizing

* Fixed balances not displaying on import left box

* Removed console logs

* Linting

* Linting

Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>

* Fixed import profile account balance

* Fixed mac plist issue

* fix empty notification (#1271)

* Use warning for websocket failure

* Filter out opt-in known accounts from creating one (#1272)

Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>

* beta v1 preparation (#1274)

* Fixed issue when put max value transaction details are not presented (#1183)

* Fixed issue when put max value transaction details are not presented

* fixed bug when put max value transaction details are not presented

* resolve transactions have the wrong amount

* Revert "Fixed issue when put max value transaction details are not presented (#1183)" (#1276)

This reverts commit 1e2ee78.

* Use account index instead of array index (#1285)

Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>

* Update curve ledger (#1279)

* Update support Ledger Symbol app to version 0.0.9

- Add Ed25519 curve option when derive Ledger account
- Update Ledger app version checking function

* Update support Ledger Symbol app to version 0.0.9

- Add Ed25519 curve option when derive Ledger account
- Update Ledger app version checking function

* Fixed leger opt in profile cannot create more than 1 child account issue

* Fix Ledger (optin and normal) profile issues

- Update create profile flow (follow import mnemonic profiles)
- Add error handler Ledger connection issues
- Remove password input field for Opt-in Ledger profiles
- Add loading UI when loading Ledger accounts

Co-authored by: Tri Vo <tri.vo@fdssoft.com>

* Updated some notification messages

* more chn text fix

* typo in translation

* Fixed ledger import balance not showing correctly

* Use account index instead of array index (#1285)

Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>

* Update support Ledger Symbol app to version 0.0.9

- Add Ed25519 curve option when derive Ledger account
- Update Ledger app version checking function

* Fixed leger opt in profile cannot create more than 1 child account issue

* Fix Ledger (optin and normal) profile issues

- Update create profile flow (follow import mnemonic profiles)
- Add error handler Ledger connection issues
- Remove password input field for Opt-in Ledger profiles
- Add loading UI when loading Ledger accounts

Co-authored by: Tri Vo <tri.vo@fdssoft.com>

* Updated some notification messages

* more chn text fix

* typo in translation

* Fixed ledger import balance not showing correctly

* Updated ledger with latest index fix

* update beta version

* Fixed index bug

Co-authored-by: TriPhan96 <tri.phan@fdssoft.com>
Co-authored-by: Peersyst Technology <acarrera@peersyst.com>
Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>

* Polishing offline transaction texts (#1275)

* fix offline transaction qr (#1280)

* change log

* changelog update

Co-authored-by: Baha <bahadir.yilmaz@nem.software>
Co-authored-by: yilmazbahadir <yilmazbahadir@gmail.com>
Co-authored-by: Bassem <bassem.magdyy94@gmail.com>
Co-authored-by: Oleg Lialin <olegliallin@gmail.com>
Co-authored-by: Tri Phan <62920562+TriPhan96@users.noreply.github.com>
Co-authored-by: James Lin <54219053+james-lin71@users.noreply.github.com>
Co-authored-by: myxmaster <77545287+myxmaster@users.noreply.github.com>
Co-authored-by: Yoshiyuki Ieyama <yukku0423@gmail.com>
Co-authored-by: tri-vo-fds <73923826+tri-vo-fds@users.noreply.github.com>
Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>
Co-authored-by: Peersyst Technology <acarrera@peersyst.com>
Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>
Co-authored-by: TriPhan96 <tri.phan@fdssoft.com>
rg911 added a commit that referenced this issue Mar 12, 2021
* network state reset on logout

* Duplicate notif fix (#1176)

* dup notif fix: 2 listeners(1 network-blocks, 1 for account-txs), closing txs-listener on subs/unsubs

* Removed default transaction fees

* temp hashLockListener added to announceHashAndAggregateBonded

* Fixed lockFund not get notificed issue

* dup notif fix: 2 listeners(1 network-blocks, 1 for account-txs), closing txs-listener on subs/unsubs

* temp hashLockListener added to announceHashAndAggregateBonded

* Fixed lockFund not get notificed issue

* Simply the reset signer

* Updated sdk to alpha version

* Fixed build error

Co-authored-by: Baha <bahadir.yilmaz@nem.software>
Co-authored-by: yilmazbahadir <yilmazbahadir@gmail.com>

* fix bugs (#1179)

* fix bugs

* linting

* update translation

* update translation

* update

* fix #1140

* Fixed hardcode translation (#1177)

* Fixed hardcode translation

* Corrected translation

* Update add account for Ledger profile (#1164)

Not show verification screen when creating profile and add more Ledger account

* hide message encryption on invoice page (#1153)

* moved tx export button to filters bar, added tooltips (#1152)

* Remove 'BOLOS' word on Ledger related messages (#1186)

* improve ja-JP (#1187)

* Top navbar: made icons clickable, added settings label (#1194)

* made icons clickable, added settings label

* fixed lint

* fixed test

* improved transactions table columns widths (#1191)

* Changed dashboard icons (#1192)

* changed dashboard icons

* fixed navigation tabs icons

* Invoice page: improved layout and label (#1195)

* fee selector now has full width when send is hidden

* added icon to QR download button

* moved QR to the bottom, replaced 'Assets' with 'Mosaic', hide hex if mosaic has a name

* fixed lint

* Fixed entitlement playlist issue (#1204)

* transactions table: display amounts of outgoing txs negative (#1193)

* Fixed amount not displaying for main net (#1199)

* Update Ledger creation profile flow (#1196) (#1214)

* #876: Namespaces - metadata editing - strange behaviour fixed (#1213)

* show a loading indication during asynchronous operations (#1207)

* Removing seed account limit (#1206)

* remove seed accounts limitations

* fix unit tests

* Revert "Changed dashboard icons (#1192)" (#1205)

This reverts commit d215d0a.

* fixed profile does not exist error message, changed input background, refactoring (#1201)

* Fix ci build (#1215)

* fix ci build

* update

* improve ja-JP (#1216)

* Minor capitalization problem (#1221)

* Fixed block listener not subscribed bug (#1233)

* settings: fixed account selector dropdown width (#1231)

* Fetch harvesting status periodically  (#1225)

* periodicly poll harvesting status and harvested blocks #1222

* update

* fixed create metadata confirmation layout (#1227)

* Namespaces descending sorting (#1223)

* Fixed descending sorting

* Removed spaces

* Rewrited sortingMethodChooser function

* Tried to remove extra variables

* Fixed syntax

* Create profile deletion button, move logout to top navbar (#1230)

* moved logout button from settings to top navbar

* created delete profile button in settings

* show mainnet not launched yet (#1212)

* fix #1190

* update translation

* Namespace duration fix (#1209)

* fix #1208

* fix namespace duration validation

* Issues fixes (#1189)

* fix #1106

* fixes #1162

* fix #1022

* fix #1061

* display full message in invoice fixes #1062

* fixes #560

* update

* fix #1188

* update translation

* update author

* fixes #723

* Add mosaic supply (#1202)

* add supply mosaic to aggregate fixes #1088 #723

* update

* resolving conflicts

* improve ja-JP (#1237)

* Added icon to switch language (#1240)

* Import QR improvements (#1200)

* hide fee warning if displayOnly is true

* hide QR download button, layout improvements

* Added 'Encrypted message' message and remove extra language icon (#1247)

* #881: Restrictions - presenting multisig restrictions under cosigner (#1244)

* #1029: Message with 1024 characters not possible (#1210)

* increase scrollbar thumb width/height in Chrome and Electron (#1251)

* fix duplicate error notification #1171 (#1254)

* fixing bugs (#1241)

* fix #877

* update

* fix language changing bug on login screen

* fix #1245

* linting

* fix #1246

* linting

* fix import mnemonic bug (#1224)

* fix #1219

* update

* hide hint on login when a profile doesn't have one (#1239)

* hide password hint on login screen if profile doesn't have one fixes #1238

* linting

* Added support for opt in accounts curve (#1252)

* Added support for opt in accounts curve

* Linting fixes

* Fixed UI and unable to transfer with opt in account bug

* Resolved #1253

* Fixed unit tests

Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>
Co-authored-by: Steven Liu <xian.f.liu@gmail.com>

* Fixed translations (#1198)

* fixed translations

* back up -> backup, updated Chinese translation

* Moved opt-in accounts logic from .env file to json (#1265)

Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>

* fixed wrong mosaic/amount/direction shown when editing aggregate tx (#1263)

* several modal dialog layout fixes (#1262)

* fixed edit metadata mosaic, fixed label (#1258)

* improve ja (#1256)

* replaced refresh button (#1259)

* fix #784 (#1211)

* account selection: show balance zero instead of N/A (#1226)

* login: validate password on submit (#1218)

* reset account selection when starting import (#1260)

* Updated publisher for windows to NGL

* Offline transactions feature (#1248)

* Raw skeleton

* Offline working with QR no UI

* UI improved

* Improved mock models

* Import signed QR

* Cosign with UI

* Last UI tweaks

* Fixed mainnet support

* linting fixes

* Merging error fix

* Removed ssh dependency and changed for https

* Solved signer not changing and minimal UI

* Mainnet profile first and added address to account signer field

* Added listeners to broadcast results

* Updated symbol-qr-library to alpha release and small ui fix

Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>

* Fixed balance showing problem in import

* restored previous change

* Fixed balance display for opt in account

* Check if currentProfile is initialized before initializing accounts (#1267)

Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>

* Re subscribe ws (#1266)

* re-subscriber if listener is closed

* retry reconnecting ws

* update sdk

* update

* linting

* update

* Fix Import mnemonic bad accounts (#1269)

* Profile is now created when finalizing

* Fixed balances not displaying on import left box

* Removed console logs

* Linting

* Linting

Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>

* Fixed import profile account balance

* Fixed mac plist issue

* fix empty notification (#1271)

* Use warning for websocket failure

* Filter out opt-in known accounts from creating one (#1272)

Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>

* beta v1 preparation (#1274)

* Fixed issue when put max value transaction details are not presented (#1183)

* Fixed issue when put max value transaction details are not presented

* fixed bug when put max value transaction details are not presented

* resolve transactions have the wrong amount

* Revert "Fixed issue when put max value transaction details are not presented (#1183)" (#1276)

This reverts commit 1e2ee78.

* Use account index instead of array index (#1285)

Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>

* Update curve ledger (#1279)

* Update support Ledger Symbol app to version 0.0.9

- Add Ed25519 curve option when derive Ledger account
- Update Ledger app version checking function

* Update support Ledger Symbol app to version 0.0.9

- Add Ed25519 curve option when derive Ledger account
- Update Ledger app version checking function

* Fixed leger opt in profile cannot create more than 1 child account issue

* Fix Ledger (optin and normal) profile issues

- Update create profile flow (follow import mnemonic profiles)
- Add error handler Ledger connection issues
- Remove password input field for Opt-in Ledger profiles
- Add loading UI when loading Ledger accounts

Co-authored by: Tri Vo <tri.vo@fdssoft.com>

* Updated some notification messages

* more chn text fix

* typo in translation

* Fixed ledger import balance not showing correctly

* Use account index instead of array index (#1285)

Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>

* Update support Ledger Symbol app to version 0.0.9

- Add Ed25519 curve option when derive Ledger account
- Update Ledger app version checking function

* Fixed leger opt in profile cannot create more than 1 child account issue

* Fix Ledger (optin and normal) profile issues

- Update create profile flow (follow import mnemonic profiles)
- Add error handler Ledger connection issues
- Remove password input field for Opt-in Ledger profiles
- Add loading UI when loading Ledger accounts

Co-authored by: Tri Vo <tri.vo@fdssoft.com>

* Updated some notification messages

* more chn text fix

* typo in translation

* Fixed ledger import balance not showing correctly

* Updated ledger with latest index fix

* update beta version

* Fixed index bug

Co-authored-by: TriPhan96 <tri.phan@fdssoft.com>
Co-authored-by: Peersyst Technology <acarrera@peersyst.com>
Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>

* Polishing offline transaction texts (#1275)

* fix offline transaction qr (#1280)

* change log

* changelog update

* Translations (#1296)

* Added missing chinese and japanese translations

* Linting

Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>

* fix harvesting status blinking #1289 (#1294)

* fix harvesting status blinking #1289

* update

* update

* fix message input (#1284)

* fix message input

* upd

* Update T&C (#1295)

* render updated terms.pdf

* fix Privacy styles

* lint

* update link color

* Metadata fix (#1297)

* update translation

* fix send namespace metadata

* update translation

* improve lang ja-JP (#1298)

* Updated mainnet nodes (#1304)

Co-authored-by: Baha <bahadir.yilmaz@nem.software>
Co-authored-by: yilmazbahadir <yilmazbahadir@gmail.com>
Co-authored-by: Bassem <bassem.magdyy94@gmail.com>
Co-authored-by: Oleg Lialin <olegliallin@gmail.com>
Co-authored-by: Tri Phan <62920562+TriPhan96@users.noreply.github.com>
Co-authored-by: James Lin <54219053+james-lin71@users.noreply.github.com>
Co-authored-by: myxmaster <77545287+myxmaster@users.noreply.github.com>
Co-authored-by: Yoshiyuki Ieyama <yukku0423@gmail.com>
Co-authored-by: tri-vo-fds <73923826+tri-vo-fds@users.noreply.github.com>
Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>
Co-authored-by: Peersyst Technology <acarrera@peersyst.com>
Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>
Co-authored-by: TriPhan96 <tri.phan@fdssoft.com>
Co-authored-by: OlegMakarenko <33131259+OlegMakarenko@users.noreply.github.com>
@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Mar 24, 2021

@bassemmagdy this was fixed but doesn't work again.

@cryptoBeliever
Copy link
Contributor

INFO: Remember to check if the current node is a peer node.

@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Jun 5, 2021

Fixed on branch gh1106-fix. Looks correct.

@cryptoBeliever cryptoBeliever moved this from Feature ready for testing to Ready for integration testing in Symbol Desktop Wallet Jun 9, 2021
bassemmagdy added a commit that referenced this issue Jun 16, 2021
* fix connected nodes doesn't show up in node selector harvesting #1106

* update peerNodes
@cryptoBeliever
Copy link
Contributor

@bassemmagdy

branch: sprint-fixes

  1. I added node 162.55.86.156
  2. Switched to harvesting view
  3. Check harvesting node list

Result: 162.55.86.156 is not visible on the list
Expected result: 162.55.86.156 is visible on the list

bassemmagdy added a commit that referenced this issue Jun 18, 2021
* fix scrolling on aggregate tx page (#1352)

* fix: balance aligment UI issue. (#1521)

* checks if bonded is signed in transactions history list  (#1522)

* checks if bonded is signed in transactions history list #1488

* Update src/language/zh-CN.json

Co-authored-by: Anthony Law <yc-law1015@hotmail.com>

* refactor needsCosignature check to async

Co-authored-by: Anthony Law <yc-law1015@hotmail.com>

* bugfix/Scanning a qr with no mosaics breaks the wallet (#1518)

* fix Scanning a QR Code for a Transfer Transaction without Mosaics breaks the Wallet #1503

* fix fees list consistency

* fix mosaic amount sometimes not shown while importing mnemonic (#1517)

* fix #1514

* add loader on fetching accounts balances

* remove setTimeout

* enhance profile creation phrasing (#1512)

* Rephrased profile creation

* fix #930

Co-authored-by: olegliallin <olegliallin@gmail.com>

* fix wrong expired message for mosaics with 0 balance #1468 (#1511)

* fix setting popup styles (#1509)

* fix setting popup styles #1448

* fix redundant scrollbar

* fix fees not always displayed

* fix scrollbar issue

* update settings modal

* Gh1431 harvesting fix (#1528)

* fix #1431 #1332

* fix harvesting showing wrong status on fresh accounts

* fix #1264 (#1480)

* fix error message while creating new profile on ledger (#1508)

* fix error message while creating new profile on ledger #1483

* remove logs

* fix icons inconsistency (#1507)

* fix iconsconsistency #1446

* update multisigForm add button styles

* fix button style

* fix #1445

* fix #1472 (#1506)

* Fix harvesting tabs alignment  (#1500)

* sort fees selector options #1430

* fix tab alignments in harvesting page #1441

* fixes #1491

* update fees selector

* fix amount field bug while importing transaction from a qr-code (#1485)

* fix #1459 (#1460)

* fix date not showing properly for aggregate transactions #1459

* fix transfer transaction date diplay

* update hashlock date representation

* Fix log in/log out spelling (#1450)

"Log in/out" is a verb, whereas "login/logout" are nouns.

* fix #1076 #1416 (#1449)

* fix #1076 #1416

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* update settings modal to select networkTab when opened from node selector

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* fix #873 (#1458)

* fix #873

* update namespaceTableService

* fix expiry checkbox

* fix validation for namespace name #1376 (#1452)

* fix validation for namespace name #1376

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* add comment to update regex when rest is fixed

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* fix: namespace expired logic error. (#1525)

* display delegate harvesting message properly (#1513)

* fix connected nodes doesn't show up in node selector harvesting (#1502)

* fix connected nodes doesn't show up in node selector harvesting #1106

* update peerNodes

* fix un-signed transactions disappear after signing another partial #1487 (#1499)

* fix the unablity to add node when all default nodes offline #1236 (#1489)

* fix #1432 (#1439)

* fix Harvesting when importing harvesting private key from node operator #1432

* fix #1432

* Update NetworkNodeSelectorTs.ts

* fix translation in login page

* Gh1090 improve transaction previews (#1540)

* improve transactiondashboard preview #1190

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* update mosaic list tooltip

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* Revert "Gh1090 improve transaction previews (#1540)" (#1543)

This reverts commit 12a0d3d.

* fix #1432

Co-authored-by: myxmaster <77545287+myxmaster@users.noreply.github.com>
Co-authored-by: Anthony Law <yc-law1015@hotmail.com>
Co-authored-by: olegliallin <olegliallin@gmail.com>
Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>
@cryptoBeliever cryptoBeliever moved this from Ready for integration testing to Feature ready for testing in Symbol Desktop Wallet Jun 21, 2021
@surekabpm surekabpm moved this from Feature ready for testing to Ready for integration testing in Symbol Desktop Wallet Jun 22, 2021
@cryptoBeliever cryptoBeliever moved this from Ready for integration testing to Feature ready for testing in Symbol Desktop Wallet Jun 22, 2021
@cryptoBeliever cryptoBeliever moved this from Feature ready for testing to Ready for integration testing in Symbol Desktop Wallet Jun 22, 2021
@cryptoBeliever cryptoBeliever moved this from Ready for integration testing to Sprint 2 in Symbol Desktop Wallet Jun 22, 2021
@cryptoBeliever
Copy link
Contributor

Fixed in integration branch.

Symbol Desktop Wallet automation moved this from Sprint_02 Backlog to Quality Assurance Jun 25, 2021
@cryptoBeliever cryptoBeliever moved this from Quality Assurance to Done in Symbol Desktop Wallet Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Issue Minor defect in aesthetics
Projects
Development

Successfully merging a pull request may close this issue.

3 participants