Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harvesting - Problem when importing harvesting private key on other device - node is not saved #1431

Closed
cryptoBeliever opened this issue Apr 15, 2021 · 2 comments · Fixed by #1436
Closed

Harvesting - Problem when importing harvesting private key on other device - node is not saved #1431

cryptoBeliever opened this issue Apr 15, 2021 · 2 comments · Fixed by #1436
Assignees
@bassemmagdy
Labels
harvesting Issue related with harvesting P3 Issue Minor defect in aesthetics
Projects
Symbol Desktop Wallet

Comments

@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Apr 15, 2021 •
edited
Loading

Steps:

  1. Start harvesting on one device (you have link node, vrf, remote).
  2. Try import a private key on another device

Result:

image

Which is correct. When we fill node we receiving correct status of harvesting:

image

But when we now go to other view and go back node is cleared. It shouldn't be.
@cryptoBeliever cryptoBeliever changed the title Problem when importing harvesting private key on other device - node is not saved Harvesting - Problem when importing harvesting private key on other device - node is not saved Apr 15, 2021
bassemmagdy added a commit that referenced this issue Apr 16, 2021
@bassemmagdy
fix #1431 #1332
013c95a
@bassemmagdy bassemmagdy mentioned this issue Apr 16, 2021
Merged
@Peersyst Peersyst linked a pull request Apr 16, 2021 that will close this issue
fix harvesting problem when activated on different device #1436
Merged
@Peersyst Peersyst added this to Issue Backlog in Symbol Desktop Wallet via automation Apr 16, 2021
@Peersyst Peersyst added the P3 Issue Minor defect in aesthetics label Apr 16, 2021
@Peersyst Peersyst moved this from Issue Backlog to Feature ready for testing in Symbol Desktop Wallet Apr 16, 2021
@cryptoBeliever cryptoBeliever added the harvesting Issue related with harvesting label Jun 5, 2021
This was referenced Jun 9, 2021
Closed
Merged
@postoronnii
Copy link

fixed

@cryptoBeliever cryptoBeliever moved this from Feature ready for testing to Ready for integration testing in Symbol Desktop Wallet Jun 13, 2021
bassemmagdy added a commit that referenced this issue Jun 14, 2021
@bassemmagdy
fix harvesting problem when activated on different device (#1436)
4021075 
* fix #1431 #1332

* fix harvesting showing wrong status on fresh accounts
@bassemmagdy bassemmagdy mentioned this issue Jun 14, 2021
Merged
bassemmagdy added a commit that referenced this issue Jun 14, 2021
@bassemmagdy
Gh1431 harvesting fix (#1528)
ac6e481 
* fix #1431 #1332

* fix harvesting showing wrong status on fresh accounts
@bassemmagdy bassemmagdy mentioned this issue Jun 18, 2021
Merged
bassemmagdy added a commit that referenced this issue Jun 18, 2021
@bassemmagdy @myxmaster
@AnthonyLaw @OlegLialin @segfaultxavi
Sprint 1 fixes (#1542)
38a7591 
* fix scrolling on aggregate tx page (#1352)

* fix: balance aligment UI issue. (#1521)

* checks if bonded is signed in transactions history list  (#1522)

* checks if bonded is signed in transactions history list #1488

* Update src/language/zh-CN.json

Co-authored-by: Anthony Law <yc-law1015@hotmail.com>

* refactor needsCosignature check to async

Co-authored-by: Anthony Law <yc-law1015@hotmail.com>

* bugfix/Scanning a qr with no mosaics breaks the wallet (#1518)

* fix Scanning a QR Code for a Transfer Transaction without Mosaics breaks the Wallet #1503

* fix fees list consistency

* fix mosaic amount sometimes not shown while importing mnemonic (#1517)

* fix #1514

* add loader on fetching accounts balances

* remove setTimeout

* enhance profile creation phrasing (#1512)

* Rephrased profile creation

* fix #930

Co-authored-by: olegliallin <olegliallin@gmail.com>

* fix wrong expired message for mosaics with 0 balance #1468 (#1511)

* fix setting popup styles (#1509)

* fix setting popup styles #1448

* fix redundant scrollbar

* fix fees not always displayed

* fix scrollbar issue

* update settings modal

* Gh1431 harvesting fix (#1528)

* fix #1431 #1332

* fix harvesting showing wrong status on fresh accounts

* fix #1264 (#1480)

* fix error message while creating new profile on ledger (#1508)

* fix error message while creating new profile on ledger #1483

* remove logs

* fix icons inconsistency (#1507)

* fix iconsconsistency #1446

* update multisigForm add button styles

* fix button style

* fix #1445

* fix #1472 (#1506)

* Fix harvesting tabs alignment  (#1500)

* sort fees selector options #1430

* fix tab alignments in harvesting page #1441

* fixes #1491

* update fees selector

* fix amount field bug while importing transaction from a qr-code (#1485)

* fix #1459 (#1460)

* fix date not showing properly for aggregate transactions #1459

* fix transfer transaction date diplay

* update hashlock date representation

* Fix log in/log out spelling (#1450)

"Log in/out" is a verb, whereas "login/logout" are nouns.

* fix #1076 #1416 (#1449)

* fix #1076 #1416

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* update settings modal to select networkTab when opened from node selector

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* fix #873 (#1458)

* fix #873

* update namespaceTableService

* fix expiry checkbox

* fix validation for namespace name #1376 (#1452)

* fix validation for namespace name #1376

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* add comment to update regex when rest is fixed

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* fix: namespace expired logic error. (#1525)

* display delegate harvesting message properly (#1513)

* fix connected nodes doesn't show up in node selector harvesting (#1502)

* fix connected nodes doesn't show up in node selector harvesting #1106

* update peerNodes

* fix un-signed transactions disappear after signing another partial #1487 (#1499)

* fix the unablity to add node when all default nodes offline #1236 (#1489)

* fix #1432 (#1439)

* fix Harvesting when importing harvesting private key from node operator #1432

* fix #1432

* Update NetworkNodeSelectorTs.ts

* fix translation in login page

* Gh1090 improve transaction previews (#1540)

* improve transactiondashboard preview #1190

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* update mosaic list tooltip

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* Revert "Gh1090 improve transaction previews (#1540)" (#1543)

This reverts commit 12a0d3d.

* fix #1432

Co-authored-by: myxmaster <77545287+myxmaster@users.noreply.github.com>
Co-authored-by: Anthony Law <yc-law1015@hotmail.com>
Co-authored-by: olegliallin <olegliallin@gmail.com>
Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>
@cryptoBeliever
Copy link
Contributor Author

Fixed in integration branch

@cryptoBeliever cryptoBeliever moved this from Ready for integration testing to Done in Symbol Desktop Wallet Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassemmagdy bassemmagdy

Labels
harvesting Issue related with harvesting P3 Issue Minor defect in aesthetics
Projects
Symbol Desktop Wallet
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix harvesting problem when activated on different device symbol/desktop-wallet
3 participants
@bassemmagdy @postoronnii @cryptoBeliever