Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions for profile creation (rephrasing) #930

Closed
myxmaster opened this issue Jan 18, 2021 · 8 comments · Fixed by #1512 or #1559
Closed

Suggestions for profile creation (rephrasing) #930

myxmaster opened this issue Jan 18, 2021 · 8 comments · Fixed by #1512 or #1559
Assignees
@OlegLialin
Labels
P3 Issue Minor defect in aesthetics
Projects
Symbol Desktop Wallet

Comments

@myxmaster
Copy link
Contributor

  1. The text of the link to the profile creation page on the login page ("Create a new profile?") should just be "Create profile". It makes no sense as a question.
  2. The title on the profile creation page currently is "Access my profile". Why not just "Create profile" again?
  3. "Create mnemonic": The mnemonic is just one part of what is actually created here - a profile with accounts including addresses, public keys, private keys and a mnemonic. So the text should be "Create Profile", the subtitle could be "Create a new wallet".
  4. "Import mnemonic": Same problem, I suggest "Import Wallet" with subtitle "Create profile from existing wallet".
  5. The subtitles of Trezor and Ledger are redundant. I'm not sure if it's technically correct but something like "Create profile from Trezor/Ledger" would be better.
@myxmaster myxmaster changed the title Suggestions for profile creation Suggestions for profile creation (rephrasing) Jan 18, 2021
@jabo38
Copy link

jabo38 commented Jan 19, 2021 •
edited

  1. I guess I would word it like "No Profile? Create one." This follows the same structure and pattern as when it later says, "Do you already have a profile? Click here to login now"

  2. I guess if you are restoring a profile, technically you are "recreating my profile". So I'm not exactly sure the best term.

image

I agree the "Create mnemonic" as the bold is wrong. It should be "Create Profile" as you suggested. But I think it is fine to say "Create a mnemonic passphrase" underneath it.

Side not, "Create pneumonic" is incorrect grammar. "mnemonic" is an adjective. This is the same as saying "Create Tall" or "Create Slow". "mnemonic" as an adjective needs to be used with the noun it is modifying, in this case "passphrase".

So the clear wording should be in bold letters "Create Profile" and then underneath it "Make a mnemonic passphrase" or something along those lines.

As for the second box, same problem. It should just be "Import Profile" in bold letters, and under it, "Restore mnemonic passphrase".

  1. I agree the Trezor and Ledger Language is off.

I think it is more accurate to say "USE LEDGER" in bold, and then underneath it to say "Open your Ledger profile".

@myxmaster
Copy link
Contributor Author

  1. "Do you already have a profile? Click here to login now" is also nice. Maybe a little long, but yeah, totally fine.
  2. When you use an existing mnemonic you are technically still creating a new [symbol desktop wallet] profile since a profile consists more than just the mnemonic (e.g. contacts in address book, those are stored with the profile and will not be recreated if you enter your existing mnemonic). Also, recreation is also a way to create.
  3. Question is if people will really get used to the word "mnemonic" / use it that much in the future. In the end it is just a representation of the private key. Once you created a mnemonic [passphrase] and made your backup, you will not get in touch with it again that soon (only if you need to reimport it). Maybe we should make a tooltip helptext next to the word mnemonic and explain what it is?
  4. Agreed

@Pow1404 Pow1404 added this to Issue Backlog in Symbol Desktop Wallet Jan 22, 2021
@cryptoBeliever cryptoBeliever added bug P3 Issue Minor defect in aesthetics labels Jan 25, 2021
@OlegLialin OlegLialin moved this from Issue Backlog to In progress in Symbol Desktop Wallet Mar 4, 2021
@OlegLialin OlegLialin linked a pull request Mar 11, 2021 that will close this issue
suggestions for profile creation #1291
Closed
@OlegLialin OlegLialin moved this from In progress to Review in progress in Symbol Desktop Wallet Mar 11, 2021
bassemmagdy added a commit that referenced this issue May 31, 2021
@bassemmagdy
fix #930
a96786d
@bassemmagdy bassemmagdy mentioned this issue May 31, 2021
Merged
@bassemmagdy bassemmagdy linked a pull request May 31, 2021 that will close this issue
enhance profile creation phrasing #1512
Merged
@bassemmagdy bassemmagdy removed a link to a pull request May 31, 2021
suggestions for profile creation #1291
Closed
@postoronnii
Copy link

fixed

@cryptoBeliever cryptoBeliever moved this from Feature ready for testing to Ready for integration testing in Symbol Desktop Wallet Jun 10, 2021
bassemmagdy added a commit that referenced this issue Jun 14, 2021
@bassemmagdy @OlegLialin
enhance profile creation phrasing (#1512)
ef5341e 
* Rephrased profile creation

* fix #930

Co-authored-by: olegliallin <olegliallin@gmail.com>
@bassemmagdy bassemmagdy mentioned this issue Jun 18, 2021
Merged
bassemmagdy added a commit that referenced this issue Jun 18, 2021
@bassemmagdy @myxmaster
@AnthonyLaw @OlegLialin @segfaultxavi
Sprint 1 fixes (#1542)
38a7591 
* fix scrolling on aggregate tx page (#1352)

* fix: balance aligment UI issue. (#1521)

* checks if bonded is signed in transactions history list  (#1522)

* checks if bonded is signed in transactions history list #1488

* Update src/language/zh-CN.json

Co-authored-by: Anthony Law <yc-law1015@hotmail.com>

* refactor needsCosignature check to async

Co-authored-by: Anthony Law <yc-law1015@hotmail.com>

* bugfix/Scanning a qr with no mosaics breaks the wallet (#1518)

* fix Scanning a QR Code for a Transfer Transaction without Mosaics breaks the Wallet #1503

* fix fees list consistency

* fix mosaic amount sometimes not shown while importing mnemonic (#1517)

* fix #1514

* add loader on fetching accounts balances

* remove setTimeout

* enhance profile creation phrasing (#1512)

* Rephrased profile creation

* fix #930

Co-authored-by: olegliallin <olegliallin@gmail.com>

* fix wrong expired message for mosaics with 0 balance #1468 (#1511)

* fix setting popup styles (#1509)

* fix setting popup styles #1448

* fix redundant scrollbar

* fix fees not always displayed

* fix scrollbar issue

* update settings modal

* Gh1431 harvesting fix (#1528)

* fix #1431 #1332

* fix harvesting showing wrong status on fresh accounts

* fix #1264 (#1480)

* fix error message while creating new profile on ledger (#1508)

* fix error message while creating new profile on ledger #1483

* remove logs

* fix icons inconsistency (#1507)

* fix iconsconsistency #1446

* update multisigForm add button styles

* fix button style

* fix #1445

* fix #1472 (#1506)

* Fix harvesting tabs alignment  (#1500)

* sort fees selector options #1430

* fix tab alignments in harvesting page #1441

* fixes #1491

* update fees selector

* fix amount field bug while importing transaction from a qr-code (#1485)

* fix #1459 (#1460)

* fix date not showing properly for aggregate transactions #1459

* fix transfer transaction date diplay

* update hashlock date representation

* Fix log in/log out spelling (#1450)

"Log in/out" is a verb, whereas "login/logout" are nouns.

* fix #1076 #1416 (#1449)

* fix #1076 #1416

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* update settings modal to select networkTab when opened from node selector

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* fix #873 (#1458)

* fix #873

* update namespaceTableService

* fix expiry checkbox

* fix validation for namespace name #1376 (#1452)

* fix validation for namespace name #1376

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* add comment to update regex when rest is fixed

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* fix: namespace expired logic error. (#1525)

* display delegate harvesting message properly (#1513)

* fix connected nodes doesn't show up in node selector harvesting (#1502)

* fix connected nodes doesn't show up in node selector harvesting #1106

* update peerNodes

* fix un-signed transactions disappear after signing another partial #1487 (#1499)

* fix the unablity to add node when all default nodes offline #1236 (#1489)

* fix #1432 (#1439)

* fix Harvesting when importing harvesting private key from node operator #1432

* fix #1432

* Update NetworkNodeSelectorTs.ts

* fix translation in login page

* Gh1090 improve transaction previews (#1540)

* improve transactiondashboard preview #1190

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* update mosaic list tooltip

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* Revert "Gh1090 improve transaction previews (#1540)" (#1543)

This reverts commit 12a0d3d.

* fix #1432

Co-authored-by: myxmaster <77545287+myxmaster@users.noreply.github.com>
Co-authored-by: Anthony Law <yc-law1015@hotmail.com>
Co-authored-by: olegliallin <olegliallin@gmail.com>
Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>
@cryptoBeliever
Copy link
Contributor

I think it is more accurate to say "USE LEDGER" in bold, and then underneath it to say "Open your Ledger profile".

@bassemmagdy @NikolaiB what with Ledger wording? Was decided to not change it?

@postoronnii
Copy link

fixed

@surekabpm
Copy link

can we close this issue @NikolaiB , if so pls close it

@postoronnii postoronnii reopened this Jun 23, 2021
Symbol Desktop Wallet automation moved this from Ready for integration testing to Doing Jun 23, 2021
bassemmagdy added a commit that referenced this issue Jun 24, 2021
@bassemmagdy
fix ledger translation #930
2a6b319
@bassemmagdy bassemmagdy linked a pull request Jun 24, 2021 that will close this issue
fix ledger translation #1559
Merged
@bassemmagdy bassemmagdy mentioned this issue Jun 24, 2021
Merged
bassemmagdy added a commit that referenced this issue Jun 24, 2021
@bassemmagdy
fix ledger translation #930 (#1559)
e41039d
bassemmagdy added a commit that referenced this issue Jun 24, 2021
@bassemmagdy
fix trasaction signing icon doesn't show immediately after signing #1488
92b69cb 
 #930
@bassemmagdy bassemmagdy mentioned this issue Jun 24, 2021
Merged
bassemmagdy added a commit that referenced this issue Jun 25, 2021
@bassemmagdy
fix trasaction signing icon doesn't show immediately after signing #1488
c865cc6 
 #930 (#1560)
@cryptoBeliever
Copy link
Contributor

Fixed in integration branch.

Symbol Desktop Wallet automation moved this from In Progress to Quality Assurance Jun 25, 2021
@cryptoBeliever
Copy link
Contributor

image

@cryptoBeliever cryptoBeliever moved this from Quality Assurance to Done in Symbol Desktop Wallet Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlegLialin OlegLialin

Labels
P3 Issue Minor defect in aesthetics
Projects
Symbol Desktop Wallet
  
Done
Milestone
No milestone
7 participants
@jabo38 @postoronnii @cryptoBeliever @OlegLialin @surekabpm @Pow1404 @myxmaster