Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harvesting - Problem when importing harvesting private key from node operator on other device - not valid status #1432

Closed
cryptoBeliever opened this issue Apr 15, 2021 · 6 comments · Fixed by #1439
Closed

Harvesting - Problem when importing harvesting private key from node operator on other device - not valid status #1432

cryptoBeliever opened this issue Apr 15, 2021 · 6 comments · Fixed by #1439
Assignees
@bassemmagdy
Labels
harvesting Issue related with harvesting P3 Issue Minor defect in aesthetics
Projects
Symbol Desktop Wallet

Comments

@cryptoBeliever
Copy link
Contributor

Preconditions: I have the private key for account that harvesting directly on node (node operator account) with linked only VRF and Remote account (without node link).

Steps:

  1. Import private key for an account above
  2. Go to harvesting view
  3. You have view as follow on harvesting:

image

  1. When we try put node manually nothing happens. Only /node/info endpoint is called. Status is not changing..
@cryptoBeliever cryptoBeliever changed the title Problem when importing harvesting private key from node operator on other device - not valid status Harvesting - Problem when importing harvesting private key from node operator on other device - not valid status Apr 15, 2021
bassemmagdy added a commit that referenced this issue Apr 16, 2021
@bassemmagdy
fix Harvesting when importing harvesting private key from node operator
0845fe4 
#1432
bassemmagdy added a commit that referenced this issue Apr 16, 2021
@bassemmagdy
fix #1432
ff37394
@bassemmagdy bassemmagdy linked a pull request Apr 16, 2021 that will close this issue
fix #1432 #1439
Merged
@bassemmagdy bassemmagdy added this to Issue Backlog in Symbol Desktop Wallet via automation Apr 16, 2021
@bassemmagdy bassemmagdy added the P3 Issue Minor defect in aesthetics label Apr 16, 2021
@bassemmagdy bassemmagdy moved this from Issue Backlog to Feature ready for testing in Symbol Desktop Wallet Apr 16, 2021
@bassemmagdy bassemmagdy self-assigned this Apr 20, 2021
@cryptoBeliever cryptoBeliever added the harvesting Issue related with harvesting label Jun 5, 2021
@cryptoBeliever
Copy link
Contributor Author

Not fixed. When you switch to another view and go back you have to put node again.

@bassemmagdy
Copy link
Contributor

@cryptoBeliever this is a seperate issue and fixed in a different pr

@cryptoBeliever
Copy link
Contributor Author

I see thanks :)

@cryptoBeliever cryptoBeliever moved this from Feature ready for testing to Ready for integration testing in Symbol Desktop Wallet Jun 9, 2021
bassemmagdy added a commit that referenced this issue Jun 16, 2021
@bassemmagdy
fix #1432 (#1439)
592c32b 
* fix Harvesting when importing harvesting private key from node operator #1432

* fix #1432

* Update NetworkNodeSelectorTs.ts
@postoronnii
Copy link

@bassemmagdy When I import an account with private key, I can see that the node status is Key Linked instead of Active

image

image

bassemmagdy added a commit that referenced this issue Jun 17, 2021
@bassemmagdy
fix #1432
a38e513
@bassemmagdy bassemmagdy mentioned this issue Jun 18, 2021
Merged
bassemmagdy added a commit that referenced this issue Jun 18, 2021
@bassemmagdy @myxmaster
@AnthonyLaw @OlegLialin @segfaultxavi
Sprint 1 fixes (#1542)
38a7591 
* fix scrolling on aggregate tx page (#1352)

* fix: balance aligment UI issue. (#1521)

* checks if bonded is signed in transactions history list  (#1522)

* checks if bonded is signed in transactions history list #1488

* Update src/language/zh-CN.json

Co-authored-by: Anthony Law <yc-law1015@hotmail.com>

* refactor needsCosignature check to async

Co-authored-by: Anthony Law <yc-law1015@hotmail.com>

* bugfix/Scanning a qr with no mosaics breaks the wallet (#1518)

* fix Scanning a QR Code for a Transfer Transaction without Mosaics breaks the Wallet #1503

* fix fees list consistency

* fix mosaic amount sometimes not shown while importing mnemonic (#1517)

* fix #1514

* add loader on fetching accounts balances

* remove setTimeout

* enhance profile creation phrasing (#1512)

* Rephrased profile creation

* fix #930

Co-authored-by: olegliallin <olegliallin@gmail.com>

* fix wrong expired message for mosaics with 0 balance #1468 (#1511)

* fix setting popup styles (#1509)

* fix setting popup styles #1448

* fix redundant scrollbar

* fix fees not always displayed

* fix scrollbar issue

* update settings modal

* Gh1431 harvesting fix (#1528)

* fix #1431 #1332

* fix harvesting showing wrong status on fresh accounts

* fix #1264 (#1480)

* fix error message while creating new profile on ledger (#1508)

* fix error message while creating new profile on ledger #1483

* remove logs

* fix icons inconsistency (#1507)

* fix iconsconsistency #1446

* update multisigForm add button styles

* fix button style

* fix #1445

* fix #1472 (#1506)

* Fix harvesting tabs alignment  (#1500)

* sort fees selector options #1430

* fix tab alignments in harvesting page #1441

* fixes #1491

* update fees selector

* fix amount field bug while importing transaction from a qr-code (#1485)

* fix #1459 (#1460)

* fix date not showing properly for aggregate transactions #1459

* fix transfer transaction date diplay

* update hashlock date representation

* Fix log in/log out spelling (#1450)

"Log in/out" is a verb, whereas "login/logout" are nouns.

* fix #1076 #1416 (#1449)

* fix #1076 #1416

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* update settings modal to select networkTab when opened from node selector

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* fix #873 (#1458)

* fix #873

* update namespaceTableService

* fix expiry checkbox

* fix validation for namespace name #1376 (#1452)

* fix validation for namespace name #1376

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* add comment to update regex when rest is fixed

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* fix: namespace expired logic error. (#1525)

* display delegate harvesting message properly (#1513)

* fix connected nodes doesn't show up in node selector harvesting (#1502)

* fix connected nodes doesn't show up in node selector harvesting #1106

* update peerNodes

* fix un-signed transactions disappear after signing another partial #1487 (#1499)

* fix the unablity to add node when all default nodes offline #1236 (#1489)

* fix #1432 (#1439)

* fix Harvesting when importing harvesting private key from node operator #1432

* fix #1432

* Update NetworkNodeSelectorTs.ts

* fix translation in login page

* Gh1090 improve transaction previews (#1540)

* improve transactiondashboard preview #1190

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* update mosaic list tooltip

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* Revert "Gh1090 improve transaction previews (#1540)" (#1543)

This reverts commit 12a0d3d.

* fix #1432

Co-authored-by: myxmaster <77545287+myxmaster@users.noreply.github.com>
Co-authored-by: Anthony Law <yc-law1015@hotmail.com>
Co-authored-by: olegliallin <olegliallin@gmail.com>
Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>
@cryptoBeliever
Copy link
Contributor Author

cryptoBeliever commented Jun 23, 2021 •
edited

@bassemmagdy @AnthonyLaw

I waited for the integration test to check that -> #1432 (comment)

It doesn't work as it should:

  • node URL disappear after switching to another view

Video: https://share.getcloudapp.com/JruDn6NA

@surekabpm surekabpm moved this from Quality Assurance to Code Review/Unit Test in Symbol Desktop Wallet Jun 24, 2021
@cryptoBeliever
Copy link
Contributor Author

Fixed in integration branch.

Symbol Desktop Wallet automation moved this from Code Review/Unit Test to Quality Assurance Jun 25, 2021
@cryptoBeliever cryptoBeliever moved this from Quality Assurance to Done in Symbol Desktop Wallet Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassemmagdy bassemmagdy

Labels
harvesting Issue related with harvesting P3 Issue Minor defect in aesthetics
Projects
Symbol Desktop Wallet
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #1432 symbol/desktop-wallet
3 participants
@bassemmagdy @postoronnii @cryptoBeliever