[WIP] Elfinder #46
[WIP] Elfinder #46
Conversation
| } | ||
|
|
||
| if ($doc instanceof ImageInterface) { | ||
| $url = $this->mediaHelper->displayUrl($doc); |
There was a problem hiding this comment.
Changing this to $this->mediaHelper->displayUrl($doc, array('imagine_filter' => $this->imagineFilter)); will use imagine for the preview if it is enabled, otherwise it will automatically use the default display route.
There was a problem hiding this comment.
should we inject a imagine filter configuration then to activate this when imagine is available?
|
Using the imagine filter does not work as expected. When selecting an image using ckeditor the imagine_filter is also applied and the imagine url is returned. Therefore the change is undone. Furthermore a media browser abstraction is added, maybe only for the browse url too much atm. On the other side it is consistent with the upload helper. The media browser is implemented in symfony-cmf/create-bundle#75 for Create and adds automatically elfinder to ckeditor if elfinder is installed. |
|
@helios-ag fyi, this will provide integration between the Symfony CMF and elFinder using the FMElfinderBundle. Do you have time to help us with a quick check of the driver: |
|
@helios-ag oh indeed that would be helpful. and maybe you can also help us with the imagine question above: i guess the question boils down to if there is a way to have a separate preview image url and display url. and as a bonus, if there can be some way to select from a list of variants of the image (imagine allows us to define named filters that can scale or otherwise process the image when downloading. while still having only one version of the uploaded image so different variants can be used in different places) |
|
Rebased to include merged #48 |
|
|
||
| if ($sourceDir === $targetDir) { | ||
| // rename | ||
| // TODO rename file causes error: Detached document or new document with already existing id passed to persist() |
There was a problem hiding this comment.
Is it possible to solve this by fe. first removing the source and then create a new target object?
There was a problem hiding this comment.
this sounds like a bug in phpcr-odm. ideally we would have a PR with a failing test demonstrating the problem.
we noticed this: doctrine/phpcr-odm#262 but thats only when replacing a child, it happened when we uploaded a new image somewhere.
simply moving really should not cause issues.
There was a problem hiding this comment.
btw, in phpcr-odm the move always is both path and name, there is no distinction between rename and move. what about simply using move unless $source === $targetDir?
There was a problem hiding this comment.
The current code means you cannot rename files or folders in the same directory. If anyone has any additional information about what this bug in phpcr is I'd be willing to look into it. Right now the elfinder rename function using the phpcr driver seems to be completely broken.
| if ($doc instanceof ImageInterface) { | ||
| $url = $this->mediaHelper->displayUrl($doc); | ||
| if ($this->imagineFilter) { | ||
| $tmbUrl = $this->mediaHelper->displayUrl($doc, array( 'imagine_filter' => $this->imagineFilter )); |
There was a problem hiding this comment.
The thumbnails are used in the "Icons view" and "List view"
|
Not sure if we want to fix the last comments (after #46 (commits)) before merge. If so, someone has to take over, I will be packing my bags for holiday. |
| @@ -13,9 +13,10 @@ | |||
| <xsd:element name="extra-filter" type="xsd:string" minOccurs="0" maxOccurs="unbounded" /> | |||
| </xsd:sequence> | |||
| <xsd:attribute name="use-imagine" type="enable" /> | |||
| <xsd:attribute name="imagine-filter" type="xsd:string" /> | |||
| <xsd:attribute name="imagine-filter" type="imagine-filter" /> | |||
There was a problem hiding this comment.
this can't be right. if i read the configuration class correctly, this must be an element.
|
i have created followup tickets |
TODO to merge
//cc @sjopet