routes' names are very restrictive

[uwej711]

see: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Routing/RouteCollection.php#L103

[dbu]

hm, mine is probably too restrictive, but yours does look too permissive. it would allow spaces and whatnot in the name. do we have a spec telling what a valid route name is for symfony?

[uwej711]

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Routing/RouteCollection.php#L103

[dbu]

thanks, that was where i copied it from i think. this means we keep the current rule, right? we do not want anything in the generated name that symfony then will complain on.

[dbu]

do we use the name somewhere? maybe we could transform the passed in name with the same regexp to make it more user friendly. however, this could lead to false matches like /ö and /ä becoming both __. for the current way we build the collection, things work fine as we walk up the tree in a breadcrumb sort of way, so every route has a different length.

for the getRoutecollection implementation #5 we will need to think carefully about naming too, when dumping the whole tree we must avoid name clashes that occur with the simple replace i have.

[uwej711]

My problem was that I had a route which contains a '-' (minus) which I think is very common. Symfony later complains about the route name since it only allows letters, digits, underscore and dot. So I just took the short cut to change everything which is not letter, digit, underscore or dot to an underscore ...

[dbu]

oh hell, i must have been tired. i thought you are relaxing the expression (i confused old and new somehow).

this is definitely much better than what we had until now. we will have to think about name collisions more when we implement getRouteCollection. then we might change this one to make the naming consistent.