Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Mar 23, 2014

@dantleech abandoned this idea, but I quite like the idea. So I started to
integrate Behat into this bundle.

This would eventually replace Tests/Functional.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This context class will hold the storage-agnostic steps

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will already create auto routes before the scenario starts.. is that what you want?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, why not?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, the background is included in the test. It's just a way to share common things of scenarios.

Only test hooks are not part of a test. A test hook can be compared to PHPUnit's setUp and tearDown.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just seems a bit odd that we are testing the creation of auto routes, but the system has already created auto routes before the scenario has been executed.. might be better to have a scenario "Create blog" that ensures that the route has been created.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The background is part of the scenario. It's like you did now in the functional test: creating a createBlog method as it's common for all tests in the testcase.

@dantleech
Copy link
Member

Cool! The main reason I didn't do this is because I am still quite new to behat, and didn't want to do things wrongly and the current functional test is already good enough to test the refactoring. But +1, looking forward to seeing how this evolves :)

@wouterj
Copy link
Member Author

wouterj commented Mar 24, 2014

Also added a feature for multi language. The AutoRouteListenerTest is now fully covered by Behat. The RefreshCommandTest seems to be not testing anything...

However, there are some problems:

  • A route is not deleted when it is renamed
  • Routes stop working when working with an extended metadata

I also cannot get Behat working on travis, I can't find the error. @stof can you maybe help us here? I think it's related to the Symfony2Extension

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/exists/exist

@wouterj
Copy link
Member Author

wouterj commented Apr 3, 2014

behat is finally running on travis :)

@wouterj wouterj added this to the 1.0 milestone Jun 20, 2014
@wouterj wouterj closed this Mar 24, 2015
@wouterj wouterj deleted the behat branch March 24, 2015 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants