-
Notifications
You must be signed in to change notification settings - Fork 28
Integrating Behat #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This context class will hold the storage-agnostic steps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will already create auto routes before the scenario starts.. is that what you want?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, why not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, the background is included in the test. It's just a way to share common things of scenarios.
Only test hooks are not part of a test. A test hook can be compared to PHPUnit's setUp and tearDown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just seems a bit odd that we are testing the creation of auto routes, but the system has already created auto routes before the scenario has been executed.. might be better to have a scenario "Create blog" that ensures that the route has been created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The background is part of the scenario. It's like you did now in the functional test: creating a createBlog
method as it's common for all tests in the testcase.
Cool! The main reason I didn't do this is because I am still quite new to behat, and didn't want to do things wrongly and the current functional test is already good enough to test the refactoring. But +1, looking forward to seeing how this evolves :) |
Also added a feature for multi language. The AutoRouteListenerTest is now fully covered by Behat. The RefreshCommandTest seems to be not testing anything... However, there are some problems:
I also cannot get Behat working on travis, I can't find the error. @stof can you maybe help us here? I think it's related to the Symfony2Extension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/exists/exist
behat is finally running on travis :) |
@dantleech abandoned this idea, but I quite like the idea. So I started to
integrate Behat into this bundle.
This would eventually replace
Tests/Functional
.