Be aware of deprecations #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we do not need to make the services public here, when i found them all in doctrine/DoctrinePHPCRBundle#286 |
ElectricMaxxx
force-pushed
the
be_aware_of_deprecations
branch
from
a921da0 to
b685783
Compare
ElectricMaxxx
force-pushed
the
be_aware_of_deprecations
branch
from
b685783 to
d1d9df3
Compare
ElectricMaxxx
force-pushed
the
master-dev-kit
branch
from
9be3706 to
9ce8440
Compare
ElectricMaxxx
force-pushed
the
master-dev-kit
branch
from
fea9973 to
2eb46db
Compare
change when exist use new KERNEL_CLASS env var fixes due to style hints revert service visibility change revert it increase symfony versions use phpcr-bundle here revert 4.0 stuff here for now Merge conflicts adjust tests
ElectricMaxxx
force-pushed
the
be_aware_of_deprecations
branch
from
8efffaf to
4eb229d
Compare
|
i merge this on into the dev-kit branch not to go over two branches anymore (confuses me g) |
ElectricMaxxx
added a commit
that referenced
this pull request
Nov 3, 2017
* merge conflicts * merge conflicts * make some services public and do not use KERNEL_DIR change when exist use new KERNEL_CLASS env var fixes due to style hints revert service visibility change revert it increase symfony versions use phpcr-bundle here revert 4.0 stuff here for now Merge conflicts adjust tests * fixes due to style issue * without any symfony version * add a new service to the list to set public * remove compiler pass to make them public
ElectricMaxxx
added a commit
that referenced
this pull request
Nov 3, 2017
* merge conflicts * merge conflicts * make some services public and do not use KERNEL_DIR change when exist use new KERNEL_CLASS env var fixes due to style hints revert service visibility change revert it increase symfony versions use phpcr-bundle here revert 4.0 stuff here for now Merge conflicts adjust tests * fixes due to style issue * without any symfony version * add a new service to the list to set public * remove compiler pass to make them public
ElectricMaxxx
added a commit
that referenced
this pull request
Nov 4, 2017
* merge conflicts * merge conflicts * make some services public and do not use KERNEL_DIR change when exist use new KERNEL_CLASS env var fixes due to style hints revert service visibility change revert it increase symfony versions use phpcr-bundle here revert 4.0 stuff here for now Merge conflicts adjust tests * fixes due to style issue * without any symfony version * add a new service to the list to set public * remove compiler pass to make them public
ElectricMaxxx
added a commit
that referenced
this pull request
Nov 4, 2017
* merge conflicts * merge conflicts * make some services public and do not use KERNEL_DIR change when exist use new KERNEL_CLASS env var fixes due to style hints revert service visibility change revert it increase symfony versions use phpcr-bundle here revert 4.0 stuff here for now Merge conflicts adjust tests * fixes due to style issue * without any symfony version * add a new service to the list to set public * remove compiler pass to make them public
ElectricMaxxx
added a commit
that referenced
this pull request
Nov 8, 2017
introduce KENEL_CLASS handling, usage of newer phpcr-bundle with correct service visibility merge conflicts Be aware of deprecations (#145) * merge conflicts * merge conflicts * make some services public and do not use KERNEL_DIR change when exist use new KERNEL_CLASS env var fixes due to style hints revert service visibility change revert it increase symfony versions use phpcr-bundle here revert 4.0 stuff here for now Merge conflicts adjust tests * fixes due to style issue * without any symfony version * add a new service to the list to set public * remove compiler pass to make them public add yaml component merge conflicts
ElectricMaxxx
added a commit
that referenced
this pull request
Nov 8, 2017
* merge conflicts * merge conflicts * make some services public and do not use KERNEL_DIR change when exist use new KERNEL_CLASS env var fixes due to style hints revert service visibility change revert it increase symfony versions use phpcr-bundle here revert 4.0 stuff here for now Merge conflicts adjust tests * fixes due to style issue * without any symfony version * add a new service to the list to set public * remove compiler pass to make them public add minimum to composer.json (cherry picked from commit e4c4bc5) add yaml component move logs and cache dir use newest phpcr-bundle now fix version increase to increas phpcr-bundle (#149) DevKit updates add change log entry apply changes from styleCI
ElectricMaxxx
added a commit
that referenced
this pull request
Nov 8, 2017
* be aware of deprectations introduce KENEL_CLASS handling, usage of newer phpcr-bundle with correct service visibility merge conflicts Be aware of deprecations (#145) * merge conflicts * merge conflicts * make some services public and do not use KERNEL_DIR change when exist use new KERNEL_CLASS env var fixes due to style hints revert service visibility change revert it increase symfony versions use phpcr-bundle here revert 4.0 stuff here for now Merge conflicts adjust tests * fixes due to style issue * without any symfony version * add a new service to the list to set public * remove compiler pass to make them public add yaml component merge conflicts * Be aware of deprecations (#145) * merge conflicts * merge conflicts * make some services public and do not use KERNEL_DIR change when exist use new KERNEL_CLASS env var fixes due to style hints revert service visibility change revert it increase symfony versions use phpcr-bundle here revert 4.0 stuff here for now Merge conflicts adjust tests * fixes due to style issue * without any symfony version * add a new service to the list to set public * remove compiler pass to make them public add minimum to composer.json (cherry picked from commit e4c4bc5) add yaml component move logs and cache dir use newest phpcr-bundle now fix version increase to increas phpcr-bundle (#149) DevKit updates add change log entry apply changes from styleCI * use correct phpcr-bundle version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code helps our other bundles to avoid lots of deprecation warnings.