Quick fix for SHTB (self-hosting test bundle) server run regression #21
Conversation
|
how is this feature used? |
| require_once __DIR__.'/../../bootstrap/bootstrap.php'; | ||
|
|
||
| // fixme: hack!! | ||
| $env = 'phpcr'; |
There was a problem hiding this comment.
ah i get it now .. not sure i understand the places you marked as hack. if i get things right .. then these hacks only affect the server command? i guess it would be ideal if the env would be determined when calling the server command .. which you seem to be handling, so i am not sure why this hack here is also necessary
There was a problem hiding this comment.
The server command only uses the application to launch the server. This front controller serves the request
There was a problem hiding this comment.
i guess what is needed is to persist the env parameter pased to the server command so that it can be used when serving requests
There was a problem hiding this comment.
Maybe - or we can always launch the front controller with a specific environment, see my other comment below. I wonder if we even need Symfony for the server script.
|
i tweaked it so that the env can be overwritten via a query parameter: |
Quick fix for SHTB (self-hosting test bundle) server run regression
Since the environment refactorings the
servercommand doesn't work, this is a very quick fix. The code needs to be refactored/looked-at again. //cc @wouterjOne problem is how to choose the test environent when accessing the test server locally @ http://localhost:8000
We do need tests for the Testing bundle, although I'm not sure how this could have been tested.