Do not override error reporting configuration #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dantleech
commented
Jan 1, 2015
dantleech
commented
- Do not change the default error reporting level
- And fix call to deprecated Kernel::init
| { | ||
| parent::__construct($env, $debug); |
There was a problem hiding this comment.
I think we have to move this to the bottom of the overriden construct method. Otherwise, bundle sets won't be registered when the init method is executed.
There was a problem hiding this comment.
You also have to change the tests, as the mock builder is now ignoring the constructor, meaning the bundle sets won't be registered at all.
- And fix call to deprecated Kernel::init
dantleech
force-pushed
the
do_not_change_error_reporting
branch
from
64c5c2f to
90a7835
Compare
|
Thanks @wouterj. updated. |
|
Good to merge? |
wouterj
added a commit
that referenced
this pull request
Jan 11, 2015
Do not override error reporting configuration
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.