This repository was archived by the owner on Sep 16, 2021. It is now read-only.
[WIP] work on menu bundle upgrade #206
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| adapter: github | ||
| issue-tracker: github | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -113,6 +113,7 @@ public function configureFormFields(FormMapper $formMapper) | |
| 'options' => $child_options, | ||
| ) | ||
| ) | ||
| ->end() | ||
| ; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -169,7 +169,7 @@ public function get($name, array $options = array()) | |
| throw new \InvalidArgumentException("Menu at '$name' is misconfigured (f.e. the route might be incorrect) and could therefore not be instanciated"); | ||
| } | ||
|
|
||
| //$menuItem->setCurrentUri($this->request->getRequestUri()); | ||
|
There was a problem hiding this comment. please do not commit commented out code. to work on the upgrade towards knp menu 2.0, please do a pr against #203 - if you can keep the code style cleanups separately, we could just merge those cleanups which would be nice There was a problem hiding this comment. the call was removed on 2.0, right? does this work as expected, meaning the menu is still highlighted at the right place? or do we need something else? i think we also have some |
||
|
|
||
| return $menuItem; | ||
| } | ||
|
|
@@ -225,7 +225,7 @@ protected function find($name, array $options, $throw) | |
| && 0 === strncmp($path, $this->getMenuRoot(), strlen($this->getMenuRoot())) | ||
| ) { | ||
| // we have jackalope with a fetch depth. prefetch all menu | ||
| // nodes of all menus. | ||
| $session->getNode($this->getMenuRoot(), $this->getPrefetch() + 1); | ||
| } else { | ||
| $session->getNode($path, $this->getPrefetch()); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,6 @@ | |
| </call> | ||
| </service> | ||
|
|
||
| </services> | ||
|
|
||
| </container> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,167 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" version="1.2"> | ||
| <file source-language="en" target-language="es" datatype="plaintext" original="file.ext"> | ||
| <body> | ||
| <trans-unit id="dashboard.cmf"> | ||
| <source>dashboard.cmf</source> | ||
| <target>Symfony CMF</target> | ||
| </trans-unit> | ||
| <trans-unit id="dashboard.label_menu"> | ||
| <source>dashboard.label_menu</source> | ||
| <target>Menus</target> | ||
| </trans-unit> | ||
| <trans-unit id="dashboard.label_menu_node"> | ||
| <source>dashboard.label_menu_node</source> | ||
| <target>Nodo Menu</target> | ||
| </trans-unit> | ||
| <trans-unit id="breadcrumb.link_menu_list"> | ||
| <source>breadcrumb.link_menu_list</source> | ||
| <target>Menus</target> | ||
| </trans-unit> | ||
| <trans-unit id="breadcrumb.link_menu_create"> | ||
| <source>breadcrumb.link_menu_create</source> | ||
| <target>Crear</target> | ||
| </trans-unit> | ||
| <trans-unit id="breadcrumb.link_menu_edit"> | ||
| <source>breadcrumb.link_menu_edit</source> | ||
| <target>Editar</target> | ||
| </trans-unit> | ||
| <trans-unit id="breadcrumb.link_menu_delete"> | ||
| <source>breadcrumb.link_menu_delete</source> | ||
| <target>Eliminar</target> | ||
| </trans-unit> | ||
| <trans-unit id="breadcrumb.link_menu_node_list"> | ||
| <source>breadcrumb.link_menu_node_list</source> | ||
| <target>Nodos Menu</target> | ||
| </trans-unit> | ||
| <trans-unit id="breadcrumb.link_menu_node_create"> | ||
| <source>breadcrumb.link_menu_node_create</source> | ||
| <target>Crear</target> | ||
| </trans-unit> | ||
| <trans-unit id="breadcrumb.link_menu_node_edit"> | ||
| <source>breadcrumb.link_menu_node_edit</source> | ||
| <target>Editar</target> | ||
| </trans-unit> | ||
| <trans-unit id="breadcrumb.link_menu_node_delete"> | ||
| <source>breadcrumb.link_menu_node_delete</source> | ||
| <target>Eliminar</target> | ||
| </trans-unit> | ||
| <trans-unit id="list.label_id"> | ||
| <source>list.label_id</source> | ||
| <target>Id</target> | ||
| </trans-unit> | ||
| <trans-unit id="list.label_name"> | ||
| <source>list.label_name</source> | ||
| <target>Nombre</target> | ||
| </trans-unit> | ||
| <trans-unit id="list.label_label"> | ||
| <source>list.label_label</source> | ||
| <target>Etiqueta</target> | ||
| </trans-unit> | ||
| <trans-unit id="list.label_uri"> | ||
| <source>list.label_uri</source> | ||
| <target>URI</target> | ||
| </trans-unit> | ||
| <trans-unit id="list.label_route"> | ||
| <source>list.label_route</source> | ||
| <target>Ruta</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.group_general"> | ||
| <source>form.group_general</source> | ||
| <target>General</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.group_items"> | ||
| <source>form.group_items</source> | ||
| <target>Items</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.label_children"> | ||
| <source>form.label_children</source> | ||
| <target>Items</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.label_parent"> | ||
| <source>form.label_parent</source> | ||
| <target>Padre</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.label_name"> | ||
| <source>form.label_name</source> | ||
| <target>Nombre</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.label_label"> | ||
| <source>form.label_label</source> | ||
| <target>Etiqueta</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.label_uri"> | ||
| <source>form.label_uri</source> | ||
| <target>URI</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.label_route"> | ||
| <source>form.label_route</source> | ||
| <target>Ruta</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.label_parameters"> | ||
| <source>form.label_parameters</source> | ||
| <target>Parámetros de ruta</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.label_content"> | ||
| <source>form.label_content</source> | ||
| <target>Contenido</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.label_link_type"> | ||
| <source>form.label_link_type</source> | ||
| <target>Tipo de enlace</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.label_weak"> | ||
| <source>form.label_weak</source> | ||
| <target>Asociación débil</target> | ||
| </trans-unit> | ||
| <trans-unit id="help.items_help"> | ||
| <source>help.items_help</source> | ||
| <target>Click en cada item para editar, click derecho para crear items.</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.group_menus"> | ||
| <source>form.group_menus</source> | ||
| <target>Menu</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.label_menu_nodes"> | ||
| <source>form.label_menu_nodes</source> | ||
| <target>Menu</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.group_menu_options"> | ||
| <source>form.group_menu_options</source> | ||
| <target>Opciones de menu</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.label_display"> | ||
| <source>form.label_display</source> | ||
| <target>Desplegar</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.help_display"> | ||
| <source>form.help_display</source> | ||
| <target>Una entrada menu sólo es mostrada si la etiqueta no está vacía.</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.label_display_children"> | ||
| <source>form.label_display_children</source> | ||
| <target>Mostrar Hijos</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.help_display_children"> | ||
| <source>form.help_display_children</source> | ||
| <target>Hijos son mostrados sólo si la entrada misma es mostrada.</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.label_attributes"> | ||
| <source>form.label_attributes</source> | ||
| <target>Atributos de Menu</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.label_label_attributes"> | ||
| <source>form.label_label_attributes</source> | ||
| <target>Atributos de Etiqueta</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.label_children_attributes"> | ||
| <source>form.label_children_attributes</source> | ||
| <target>Atributos de Hijos</target> | ||
| </trans-unit> | ||
| <trans-unit id="form.label_link_attributes"> | ||
| <source>form.label_link_attributes</source> | ||
| <target>Atributos de enlace</target> | ||
| </trans-unit> | ||
| </body> | ||
| </file> | ||
| </xliff> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are not going to use gush...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try to speak for yourself, in view of such a hostile env i am closing the PRs, maybe i will try later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sad that you closed this PR because of this one little thing. It contained lots of nice changes.
In fact, there were just 2 problems with this PR (in a PR with 20+ changes):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think there was anything wrong with @wouterj’s comment. He part of the CMF core team and just expressed that he doesn’t want to introduce a new tool to the project. What’s wrong with that?