Trigger deprecation notices #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,7 +37,7 @@ before_install: | |||
| - composer self-update | |||
| - composer require symfony/symfony:${SYMFONY_VERSION} --no-update | |||
|
|
|||
| install: composer update --prefer-source $COMPOSER_FLAGS | |||
| install: composer update -vvv --prefer-source $COMPOSER_FLAGS | |||
There was a problem hiding this comment.
I hope this gives us enough time, so we can avoid using travis_wait.
There was a problem hiding this comment.
no luck. can we do something to reduce the options space? like not allow symfony > 2.3 in the lowest build?
There was a problem hiding this comment.
We already do that. Seems like it's stuck resolving jackalope, maybe we can narrow that down as well
|
still no luck. argh! can we do more? more specific versions without stars? |
wouterj
force-pushed
the
deprecation_internal
branch
from
7637f99 to
78c8a3f
Compare
|
Removed the build fixes from this PR, let's merge this and fix the lowest deps build in another PR. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony does now have really nice tools and a good handling of deprecation notices. So we should trigger deprecation notices whenever we deprecate anything.
Besides that, this 1.x release is probably one of the last releases in the 1 major so it also makes sense to warn users about deprecated features.
/cc @lsmith77 @dbu @dantleech