Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Conversation

dbu
Copy link
Member

@dbu dbu commented Jan 10, 2014

Q A
Doc fix? no
New docs? yes
Applies to MenuBundle 1.1
Fixed tickets -

document symfony-cmf/menu-bundle#166

**type**: ``integer`` **default**: ``10``

When rendering a menu, the whole menu tree needs to be loaded. To reduce the
number off database requests PHPCR needs to make, this setting makes the tree
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/off/of

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

database requests that PHPCR needs to make ?

@wouterj
Copy link
Member

wouterj commented Jan 10, 2014

FYI, I added [WCM] to your title which means Waiting Code Merge, so this PR isn't merged until the upstream PR is merged.


.. versionadded:: 1.1

This performance optimization was added in MenuBundle 1.1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually add this before the headline

@dbu
Copy link
Member Author

dbu commented Jan 10, 2014

the code is merged. removed the [WCM] again - or is that not how you do it?

@wouterj
Copy link
Member

wouterj commented Jan 10, 2014

I just watch all upstream PRs of WCM PRs and merge it when the code PR is merged. But if you're happy with removing the WCM, you can do it :)

wouterj added a commit that referenced this pull request Jan 10, 2014
document the menu prefetch option
@wouterj wouterj merged commit 76c673d into master Jan 10, 2014
@wouterj wouterj deleted the menu-prefetch branch January 10, 2014 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants