This repository was archived by the owner on Sep 16, 2021. It is now read-only.
Document potential CoreBundle requirement when DoctrineBundle <1.3 #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RoutingBundle Doctrine ORM integration requires CoreBundle to function properly if using DoctrineBundle <1.3.
| @@ -353,6 +353,9 @@ Alternatively, you can use the `Doctrine ORM`_ provider by specifying the | |||
| ``persistence.orm`` part of the configuration. It does a similar job but, as | |||
| the name indicates, loads ``Route`` entities from an ORM database. | |||
|
|
|||
| You must install the CMF `CoreBundle` to utilize this feature if your app | |||
There was a problem hiding this comment.
could you please put this in a caution directive?
(also note the small changes I made in the first sentence)
.. caution::
You must install the ``CoreBundle`` to utilize this feature if your app
does not have at least DoctrineBundle 1.3 installed.
|
good catch, thank you. are you successfully using the routing with orm? we have little experience with it and would love feedback or improvements. test coverage is not very complete and there is an open question: symfony-cmf/routing-bundle#145 - your feedback on this would be valuable. |
dbu
added a commit
that referenced
this pull request
Jan 28, 2014
Document potential CoreBundle requirement when DoctrineBundle <1.3
wouterj
added a commit
that referenced
this pull request
Jan 28, 2014
|
Fyi, I did a minor change, to be consistent with the rest of the docs in b07aaf4 |
|
thanks. sorry, hit merge a bit too fast it seems. |
|
@dbu We've got it working for simple static routes from the database so far without a hitch. We'll be utilizing more complex routes soon so hopefully I can provide feedback then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RoutingBundle Doctrine ORM integration requires CoreBundle to function properly if using DoctrineBundle <1.3.