Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Conversation

ElectricMaxxx
Copy link
Member

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #421

So...
started to refactor the example for the route provider. It isn't ready. Got some open issues:

  • just injecting the document manager instead of the document registry cause it is a very specific
    example?
  • adding the service config for yml and php
  • little refactorings in text

@ElectricMaxxx
Copy link
Member Author

merge into master should be right in here or? It's stuff that needs to go online directly, right?

@wouterj
Copy link
Member

wouterj commented Mar 22, 2014

It's stuff that needs to go online directly, right?

Indeed, it's not a feature, it's a "doc fix" so it should be merged into master

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symfony solution (the whole sentence doesn't look correct)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why "endpoint"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the name in the old example.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets just call this thing acme_demo.route_provider

@ElectricMaxxx
Copy link
Member Author

All comments of @dbu shows me, that i should have discuss a little more in the issue. It is hard to create an example of a thing that is simple in general, but can be implemented in so many different use cases. We should ask: What would be the "cmf example". I would say it should contain the cmf route and the part of setting the document.
Problem for creating something on the fly would be, that we have to explain why to return a RouteCollection. So we need to create more than one Route (reason for the candidates thing).

@dbu
Copy link
Member

dbu commented Mar 23, 2014

we can simply return a collection with just one element. and say that if your logic would support route parameters, you could end up with more than one candidate.

to me, the point of this example is how to use the DynamicRouter with something else than PHPCR or ORM which are already provided in the bundle. its more a case of: "you don't need to implement your own Router, if you want to load routes on request and the only thing that is different is how you load those routes." now for a good example, i really don't know. everything based on orm / phpcr will be difficult to make the point. maybe a route provider with elasticsearch? quite involved again... still better than doctrine mongodb as at least elasticsearch returns us arrays and is not an object-mapper, so we could create the routes from the elasticsearch information...

@lsmith77
Copy link
Member

lsmith77 commented Apr 4, 2014

ping

@ElectricMaxxx
Copy link
Member Author

Pong.

Will be back this evening. Delayed that one here.

@lsmith77 lsmith77 added this to the 1.1 milestone Apr 28, 2014
@dbu
Copy link
Member

dbu commented May 3, 2014

should we still do this or do you want to port a light version with just some tweaks into a new PR?

@ElectricMaxxx
Copy link
Member Author

👍 for doing a light example.

@dbu dbu removed this from the 1.1 milestone May 13, 2014
@dbu
Copy link
Member

dbu commented Jul 11, 2014

@ElectricMaxxx ping (sorry, guess you get a couple of emails today, i am wading through old github issues...)

@dbu
Copy link
Member

dbu commented Oct 20, 2014

shall we close this?

@wouterj
Copy link
Member

wouterj commented Oct 21, 2014

Feel free to start a new one when you have time, @ElectricMaxxx

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants