-
Notifications
You must be signed in to change notification settings - Fork 156
refactor route provider example #423
refactor route provider example #423
Conversation
merge into master should be right in here or? It's stuff that needs to go online directly, right? |
Indeed, it's not a feature, it's a "doc fix" so it should be merged into master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Symfony solution (the whole sentence doesn't look correct)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why "endpoint"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was the name in the old example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets just call this thing acme_demo.route_provider
All comments of @dbu shows me, that i should have discuss a little more in the issue. It is hard to create an example of a thing that is simple in general, but can be implemented in so many different use cases. We should ask: What would be the "cmf example". I would say it should contain the cmf route and the part of setting the document. |
we can simply return a collection with just one element. and say that if your logic would support route parameters, you could end up with more than one candidate. to me, the point of this example is how to use the DynamicRouter with something else than PHPCR or ORM which are already provided in the bundle. its more a case of: "you don't need to implement your own Router, if you want to load routes on request and the only thing that is different is how you load those routes." now for a good example, i really don't know. everything based on orm / phpcr will be difficult to make the point. maybe a route provider with elasticsearch? quite involved again... still better than doctrine mongodb as at least elasticsearch returns us arrays and is not an object-mapper, so we could create the routes from the elasticsearch information... |
ping |
Pong. Will be back this evening. Delayed that one here. |
should we still do this or do you want to port a light version with just some tweaks into a new PR? |
👍 for doing a light example. |
@ElectricMaxxx ping (sorry, guess you get a couple of emails today, i am wading through old github issues...) |
shall we close this? |
Feel free to start a new one when you have time, @ElectricMaxxx |
So...
started to refactor the example for the route provider. It isn't ready. Got some open issues:
example?