Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Conversation

dbu
Copy link
Member

@dbu dbu commented Mar 26, 2014

Q A
Doc fix? yes
New docs? yes
Applies to 1.1
Fixed tickets symfony-cmf/routing-bundle#210

locales
~~~~~~~

**type**: ``array`` **default**:
**type**: ``array`` **default**: array()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put array() in a literal (same for booleans below)

@dbu
Copy link
Member Author

dbu commented Mar 29, 2014

updated the doc. this is missing doc on the candidates things, but then that is really an implementation detail.

@dbu dbu changed the title [WCM] documentation for cleaned up routing documentation for cleaned up routing Apr 4, 2014
@dbu
Copy link
Member Author

dbu commented Apr 4, 2014

alright, this is now updated for the simplecms bundle as well. the code is merged and this should be ready to merge.

i will be away the whole next week, so if somebody can fix minor issues to make it mergeable, please do.

@lsmith77
Copy link
Member

lsmith77 commented Apr 4, 2014

@wouterj can you look into the build failure?

@wouterj
Copy link
Member

wouterj commented Apr 4, 2014

@lsmith77 build failure is not related to these changes. I'll invistigate that more after this weekend

@@ -288,6 +293,10 @@ get an error if Sonata becomes unavailable.
Sonata admin is using the ``content_basepath`` to show the tree of content to
select the route target.

The root path to add Routes defaults to the first entry in ``route_basepaths``
but you can overwrite this with the ``admin_basepath`` if you need a different
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...], but you (missing comma)

@dbu
Copy link
Member Author

dbu commented Apr 4, 2014

the build failure was me. i cleaned up the doc now. no more warnings locally.

wouterj added a commit that referenced this pull request Apr 6, 2014
@wouterj wouterj merged commit c2d5136 into dev Apr 6, 2014
@wouterj wouterj deleted the routing-configuration branch April 6, 2014 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants