Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Conversation

dbu
Copy link
Member

@dbu dbu commented May 10, 2014

Q A
Doc fix? yes
New docs? yes
Applies to 1.1+ of the doc (to also catch the new doc)
Fixed tickets -

clean up all doctrine annotations to follow the format we agreed on.

@wouterj
Copy link
Member

wouterj commented May 10, 2014

I thought we agreed on PHPCR?

@dbu
Copy link
Member Author

dbu commented May 10, 2014

argh. maybe that is why i found so many :-( but it definitely is still inconsistent. if you are sure, i can fix this the other way round then.

@wouterj
Copy link
Member

wouterj commented May 10, 2014

I'm sure now: 😉

"yes we did agree on using PHPCR as alias for the annotations"
@dbu - #303 (comment)

@dbu
Copy link
Member Author

dbu commented May 12, 2014

okay, now the other way round. it definitely was inconsistent...

@lsmith77
Copy link
Member

looks good to me

wouterj added a commit that referenced this pull request May 12, 2014
@wouterj wouterj merged commit 7975900 into dev May 12, 2014
@wouterj wouterj deleted the cleanup-phpcrodm-annotation branch May 12, 2014 07:54
@wouterj
Copy link
Member

wouterj commented May 12, 2014

Next time, we should do these things in master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants