Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Conversation

vadim2404
Copy link

No description provided.

lsmith77 added a commit that referenced this pull request Nov 1, 2014
Fix missing namespace usage
@lsmith77 lsmith77 merged commit cb09c54 into symfony-cmf:master Nov 1, 2014
@dantleech
Copy link
Member

Is this really necessary?

@wouterj
Copy link
Member

wouterj commented Nov 2, 2014

@dantleech @dbu and @lsmith77 thought so. I'm not sure where we discussed this.

@wouterj
Copy link
Member

wouterj commented Nov 2, 2014

btw, @lsmith77 , this should have been merged in 1.1.

@dantleech
Copy link
Member

@wouterj I don't remember discussing it :) To me this seems unnecessary for a tutorial, if anything I would add a comment or a note telling the user that they might want to check the type of the document manager.

But -- would this actually every happen? Are not fixtures in the PHPCR directory loaded only by the PHPCR fixture manager?

Why was it necessary to add this?

@dbu
Copy link
Member

dbu commented Nov 2, 2014

we did the same in other places. if you point to your fixtures explicitly, and use the wrong fixture command (doctrine:fixtures:load vs doctrine:phpcr:fixtures:load) you will be confused. with this change you should see what is wrong.

the discussion was in #506

@dantleech
Copy link
Member

ok thats fine then.

@vadim2404 vadim2404 deleted the patch-1 branch November 2, 2014 10:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants