Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

use travis docker env #688

Merged
merged 2 commits into from
Aug 8, 2015
Merged

use travis docker env #688

merged 2 commits into from
Aug 8, 2015

Conversation

dbu
Copy link
Member

@dbu dbu commented Jul 26, 2015

follow-up of #686 - try without installing enchant explicitly. @wouterj is that what you ment?

@dbu
Copy link
Member Author

dbu commented Jul 26, 2015

hm, does not work. @wouterj can you help me?

@wouterj
Copy link
Member

wouterj commented Jul 26, 2015

No. Enchant is put on the apt packages whitelist. Packages in this whitelist can be installed using the apt addon. This addon makes it possible to install packages in the container based environment.

-before_script:
-    - sudo apt-get install enchant
+sudo: false
+
+addons:
+    apt:
+        packages: [enchant]

@lsmith77 lsmith77 added review and removed wip/poc labels Jul 26, 2015
@dbu dbu force-pushed the travis-docker branch from 68b8787 to 206dbe6 Compare July 27, 2015 06:20
@dbu
Copy link
Member Author

dbu commented Jul 27, 2015

ah, interesting. updated the travis config file, lets see

@dbu
Copy link
Member Author

dbu commented Jul 27, 2015

the pr build is completely broken. i guess that is the same problem lukas remarked somewhere else.

but the push also fails, with lots of spelling errors. locally, i get none of these. any idea what is happening here?

@dantleech
Copy link
Member

Well, none of those words are in my gcide dictionary -- either its not taking the whitelist into account or it just suddenly started detecting more words.

@dbu
Copy link
Member Author

dbu commented Jul 27, 2015

weird. it looks like some things where previously not spell checked. there is nothing for Multi-Language in our wordlist.

@wouterj
Copy link
Member

wouterj commented Jul 27, 2015

Builds are fixed now, if you rebase things should work.

@dbu dbu force-pushed the travis-docker branch from 206dbe6 to 3d806a7 Compare July 27, 2015 15:30
@dbu
Copy link
Member Author

dbu commented Jul 27, 2015 via email

@dbu
Copy link
Member Author

dbu commented Jul 31, 2015

nope. it seems the enchant we end up with uses a different logic regarding spell checks in title. can that be the problem? do we need to update titles / add their words to the wordlist?

@dantleech
Copy link
Member

hmm, adding these words to the whitelist would solve it:

afterwards
balancer
balancers
boolean
filename
getters
initializer
initializers
licensor
login
lookup
multi
natively
pluggable
postfix
redirections
refactoring
runtime
subtree
subtrees
th
uncomment
workspaces

@dbu
Copy link
Member Author

dbu commented Aug 1, 2015

fixed a bunch of things and added words. looks like this version of enchant has thrown out a lot of technical temrs that we needed. have a close look at the spelling list.

dbu
dbu reviewed Aug 1, 2015
View reviewed changes
book/static_content.rst
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was unused

@dbu dbu force-pushed the travis-docker branch 2 times, most recently from 81085d3 to 56cef91 Compare August 1, 2015 09:25
dbu
dbu reviewed Aug 1, 2015
View reviewed changes
spelling_word_list.txt Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this incorrect? its used here https://github.com/symfony-cmf/symfony-cmf-docs/blob/master/tutorial/conclusion.rst

@dbu
Copy link
Member Author

dbu commented Aug 7, 2015

yay, green and seems good to me. @wouterj can you have a look and merge please?

wouterj added a commit that referenced this pull request Aug 8, 2015
@wouterj
Merge pull request #688 from symfony-cmf/travis-docker
86d7d62 
use travis docker env
@wouterj wouterj merged commit 86d7d62 into master Aug 8, 2015
@wouterj wouterj removed the review label Aug 8, 2015
@wouterj wouterj deleted the travis-docker branch August 8, 2015 15:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbu @wouterj @dantleech @lsmith77