Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Support imagine runtime config in display url templating helper #730

Merged
merged 1 commit into from
Jan 12, 2016
Merged

Support imagine runtime config in display url templating helper #730

merged 1 commit into from
Jan 12, 2016

Conversation

aramalipoor
Copy link
Contributor

Q A
Doc fix? no
New docs? yes symfony-cmf/media-bundle#143
Applies to MediaBundle
Fixed tickets -

'thumbnail': {'size': [120, 60]}
}
}) }}" title="Download">Download</a>
.. versionadded:: 1.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be not indented. please add a blank line after the code and then make this line without whitespace in front.

@lsmith77 lsmith77 added review and removed wip/poc labels Jan 10, 2016
@aramalipoor
Copy link
Contributor Author

@dbu Thanks for the review, anything else :) ?

dbu added a commit that referenced this pull request Jan 12, 2016
Support imagine runtime config in display url templating helper
@dbu dbu merged commit 7aa39e7 into symfony-cmf:master Jan 12, 2016
@dbu
Copy link
Member

dbu commented Jan 12, 2016

thanks!

@lsmith77 lsmith77 removed the review label Jan 12, 2016
@aramalipoor aramalipoor deleted the patch-1 branch January 12, 2016 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants