[AI Bundle] Remove unnecessary normalizeKeys(false) from options.php
#406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OskarStark
commented
Sep 2, 2025
OskarStark
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| Docs? | no |
| Issues | Fix #404 |
| License | MIT |
carsonbot
changed the title
OskarStark
changed the title
normalizeKeys(false) from options.php
carsonbot
changed the title
normalizeKeys(false) from options.phpnormalizeKeys(false) from options.php
OskarStark
commented
Sep 2, 2025
| $this->assertSame('ai.store.distance_calculator.my_memory_store_with_custom_strategy', (string) $definition->getArgument(0)); | ||
| } | ||
|
|
||
| public function testConfigurationWithUseAttributeAsKeyWorksWithoutNormalizeKeys() |
There was a problem hiding this comment.
We can also remove this test case before merging, I just wanted to showcase, that it is working
chr-hertel
approved these changes
Sep 2, 2025
OskarStark
force-pushed
the
fix/remove-unnecessary-normalize-keys
branch
from
f57f0ae to
46789a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.