[AI-Bundle] Fix processor config #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
VincentLanglet
commented
Sep 3, 2025
VincentLanglet
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| Docs? | no |
| Issues | Fix #... |
| License | MIT |
VincentLanglet
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
chr-hertel
approved these changes
Sep 3, 2025
chr-hertel
force-pushed
the
fixConfig
branch
from
1c66227 to
9018ed9
Compare
|
Thank you @VincentLanglet. |
|
What could be nice (to avoid such regression) @chr-hertel is some functional test about the AiBundle config. Does someone plan to work on it ? (Maybe while the hackathon ?) |
|
Thanks! |
OskarStark
added a commit
to OskarStark/ai
that referenced
this pull request
Sep 4, 2025
This commit adds comprehensive tests for processor configuration to ensure
that processor tags always use the full agent ID (ai.agent.{name}) instead
of just the agent name. This prevents regressions like the one fixed in symfony#428.
The tests cover:
- Tool processor tags for specific and default toolboxes
- Structured output processor tags
- System prompt processor tags
- Token usage processor tags
- Multiple agents with their own processors
- Special characters in agent names
Co-Authored-By: Claude <noreply@anthropic.com>
OskarStark
added a commit
to OskarStark/ai
that referenced
this pull request
Sep 4, 2025
This commit adds comprehensive tests for processor configuration to ensure
that processor tags always use the full agent ID (ai.agent.{name}) instead
of just the agent name. This prevents regressions like the one fixed in symfony#428.
The tests cover:
- Tool processor tags for specific and default toolboxes
- Structured output processor tags
- System prompt processor tags
- Token usage processor tags
- Multiple agents with their own processors
- Special characters in agent names
Co-Authored-By: Claude <noreply@anthropic.com>
OskarStark
added a commit
to OskarStark/ai
that referenced
this pull request
Sep 4, 2025
This commit adds comprehensive tests for processor configuration to ensure
that processor tags always use the full agent ID (ai.agent.{name}) instead
of just the agent name. This prevents regressions like the one fixed in symfony#428.
The tests cover:
- Tool processor tags for specific and default toolboxes
- Structured output processor tags
- System prompt processor tags
- Token usage processor tags
- Multiple agents with their own processors
- Special characters in agent names
Co-Authored-By: Claude <noreply@anthropic.com>
OskarStark
added a commit
to OskarStark/ai
that referenced
this pull request
Sep 4, 2025
This commit adds comprehensive tests to AiBundleTest that verify processor
tags use the full agent ID (ai.agent.{name}) instead of just the agent name.
The tests cover:
- Tool processor tags (for both specific and default toolboxes)
- Structured output processor tags
- System prompt processor tags
- Token usage processor tags
- Multiple agents with their own processors
These tests ensure the fix from PR symfony#428 continues to work correctly.
OskarStark
added a commit
to OskarStark/ai
that referenced
this pull request
Sep 4, 2025
This commit adds comprehensive tests to AiBundleTest that verify processor
tags use the full agent ID (ai.agent.{name}) instead of just the agent name.
The tests cover:
- Tool processor tags (for both specific and default toolboxes)
- Structured output processor tags
- System prompt processor tags
- Token usage processor tags
- Multiple agents with their own processors
These tests ensure the fix from PR symfony#428 continues to work correctly.
OskarStark
added a commit
to OskarStark/ai
that referenced
this pull request
Sep 4, 2025
This commit adds comprehensive tests to AiBundleTest that verify processor
tags use the full agent ID (ai.agent.{name}) instead of just the agent name.
The tests cover:
- Tool processor tags (for both specific and default toolboxes)
- Structured output processor tags
- System prompt processor tags
- Token usage processor tags
- Multiple agents with their own processors
These tests ensure the fix from PR symfony#428 continues to work correctly.
Tests use TestDox attributes for better documentation.
OskarStark
added a commit
that referenced
this pull request
Sep 4, 2025
This PR was squashed before being merged into the main branch. Discussion ---------- [AI Bundle] Add tests for processors | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | Follows #428 | License | MIT cc `@VincentLanglet` Commits ------- c43991b [AI Bundle] Add tests for processors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.