-
-
Notifications
You must be signed in to change notification settings - Fork 103
[AI Bundle] Add tests for processors #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AI Bundle] Add tests for processors #430
Conversation
152b506
to
73381c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug where processor tags were using incomplete agent IDs instead of the full agent service IDs. The issue was that tags were using the variable $agentId
(which contained just the agent name) instead of the properly prefixed 'ai.agent.'.$name
format.
- Replaces
$agentId
variable usage with hardcoded'ai.agent.'.$name
string concatenation in processor tag assignments - Adds comprehensive test coverage to verify processor tags use the correct full agent IDs
- Ensures all processor types (tool, structured output, token usage, system prompt) properly reference their associated agents
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
File | Description |
---|---|
src/ai-bundle/src/AiBundle.php | Fixes processor tag agent IDs to use full 'ai.agent.'.$name format instead of incomplete $agentId variable |
src/ai-bundle/tests/DependencyInjection/ProcessorConfigurationTest.php | Adds comprehensive test coverage for processor tag configuration validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
55240fe
to
cf9d3c0
Compare
5a9d078
to
4b7fa8b
Compare
4b7fa8b
to
b369d3b
Compare
b369d3b
to
c43991b
Compare
cc @VincentLanglet