Skip to content

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Sep 4, 2025

Q A
Bug fix? no
New feature? no
Docs? no
Issues Follows #428
License MIT

cc @VincentLanglet

@OskarStark OskarStark self-assigned this Sep 4, 2025
@carsonbot carsonbot added AI Bundle Issues & PRs about the AI integration bundle Bug Something isn't working Status: Needs Review labels Sep 4, 2025
@OskarStark OskarStark force-pushed the fix-processor-configuration-tests branch 6 times, most recently from 152b506 to 73381c3 Compare September 4, 2025 05:19
@OskarStark OskarStark requested a review from Copilot September 4, 2025 05:55
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where processor tags were using incomplete agent IDs instead of the full agent service IDs. The issue was that tags were using the variable $agentId (which contained just the agent name) instead of the properly prefixed 'ai.agent.'.$name format.

  • Replaces $agentId variable usage with hardcoded 'ai.agent.'.$name string concatenation in processor tag assignments
  • Adds comprehensive test coverage to verify processor tags use the correct full agent IDs
  • Ensures all processor types (tool, structured output, token usage, system prompt) properly reference their associated agents

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
src/ai-bundle/src/AiBundle.php Fixes processor tag agent IDs to use full 'ai.agent.'.$name format instead of incomplete $agentId variable
src/ai-bundle/tests/DependencyInjection/ProcessorConfigurationTest.php Adds comprehensive test coverage for processor tag configuration validation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@OskarStark OskarStark force-pushed the fix-processor-configuration-tests branch 4 times, most recently from 55240fe to cf9d3c0 Compare September 4, 2025 06:20
@OskarStark OskarStark changed the title [AI Bundle] Fix processor tags to use full agent IDs [AI Bundle] Add tests Sep 4, 2025
@OskarStark OskarStark force-pushed the fix-processor-configuration-tests branch 2 times, most recently from 5a9d078 to 4b7fa8b Compare September 4, 2025 06:27
@OskarStark OskarStark changed the title [AI Bundle] Add tests [AI Bundle] Add tests for processors Sep 4, 2025
@OskarStark OskarStark force-pushed the fix-processor-configuration-tests branch from 4b7fa8b to b369d3b Compare September 4, 2025 06:36
@OskarStark OskarStark force-pushed the fix-processor-configuration-tests branch from b369d3b to c43991b Compare September 4, 2025 07:45
@OskarStark OskarStark merged commit dd94256 into symfony:main Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Bundle Issues & PRs about the AI integration bundle Bug Something isn't working Status: Reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants