[Platform] Remove default model names from constructor parameters #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
OskarStark
force-pushed
the
remove-default-models
branch
from
b982315 to
a5c7bc0
Compare
OskarStark
added a commit
to OskarStark/ai
that referenced
this pull request
Sep 23, 2025
After PR symfony#577, model names can no longer be null as default model names were removed from Model class constructors. This change: - Makes model name required in configuration (options.php) - Removes null checks when setting model name argument (AiBundle.php)
OskarStark
added a commit
that referenced
this pull request
Sep 23, 2025
…arameters (OskarStark) This PR was squashed before being merged into the main branch. Discussion ---------- [Platform] Remove default model names from constructor parameters | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Docs? | no | Issues | Forgotten in #577 | License | MIT Commits ------- 70e86c2 [Platform] Remove default model names from constructor parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes default model names from all Model class constructors to prevent breaking changes when default models are changed. Model names must now be explicitly provided when instantiating model classes.